Move "ips" field from Subnet object to VIF object
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
os-vif |
Fix Released
|
High
|
Rodolfo Alonso |
Bug Description
"ips" field in Subnet object [1] is a legacy field from Nova networks. This is still used in the virt Firewall, but is not used in os-vif project. Furthemore, the VIF object used by Nova to extract the port IPs [2] is not provided by os-vif.
The reason to move this field from Subnet to VIF is because the IP list should belong to the VIF object, which is linked with the port. The Subnet object contains the CIDR of the subnetwork, but shouldn't store the IPs given to an specific port.
This object modification should be ready before the os-vif Neutron/Nova migration process.
[1] https:/
[2] https:/
this is currently not used by anyting in os-vif so we should remove it before anything uses it incorrectly.
as pointed out this is legacy code form when the subnet object was imported for nova networks originally and it is only used for firwalling when not using neutron.
in the legacy nova-networks code path currently nova does not use the os-vif object when creating the firewall rules, only when pluging the interface so there is no use of these field in nova either so its safe to remove them from the subnet object in os-vif.