HostPluginInfo.plugin_name error in tests

Bug #1714472 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-vif
Fix Released
Undecided
Rodolfo Alonso

Bug Description

There is an error in the "plugin_name" field of HostPluginInfo object:
https://github.com/openstack/os-vif/blob/master/os_vif/tests/unit/test_host_info.py#L26

This mistake could be common is we allow developers to use strings. Instead of this I'm going to propose a change modifying HostPluginInfo.plugin_name to a custom class called OsvifPluginNameEnumField.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-vif (master)

Fix proposed to branch: master
Review: https://review.openstack.org/500111

Changed in os-vif:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-vif (master)

Reviewed: https://review.openstack.org/500111
Committed: https://git.openstack.org/cgit/openstack/os-vif/commit/?id=9fbc124f7f20dba8e4dc40b8098d89b9a32f0a52
Submitter: Jenkins
Branch: master

commit 9fbc124f7f20dba8e4dc40b8098d89b9a32f0a52
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Sep 1 11:25:50 2017 +0100

    Add plugin names as constants.

    HostPluginInfo plugin_name field is the name of the possible
    different plugins that could be used, defined in-tree or out-of-tree
    this project.

    To avoid typing errors, PLUGIN_NAME constant is added to each project.

    Closes-Bug: #1714472
    Change-Id: Ibb3b65314958ae56a2389704903c04dc985114d7

Changed in os-vif:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-vif 1.8.0

This issue was fixed in the openstack/os-vif 1.8.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.