Missing image type 'ploop'

[Eric Xie]

Description of the problem
======================
Missing image type 'ploop'

Recreate steps
============
1. upload image: openstack image creat --file xxx.img --disk-format ploop --container-format bare --public test-ploop
2. configure: [scheduler]/query_placement_for_image_type_support=true, then restart devstack@n-sch
3. create server: openstack server create --flavor flv-cpu --image test-ploop --network private vm-test

Expected:
The server created fail.

Actual:
server created successfully.

Traits of compute node:
# openstack --os-placement-api-version 1.6 resource provider trait list 98029e51-2f81-46a3-9746-443174a1ba51
+---------------------------------------+
| name |
+---------------------------------------+
| HW_CPU_HYPERTHREADING |
| COMPUTE_IMAGE_TYPE_RAW |
| HW_CPU_X86_SSE2 |
| HW_CPU_X86_SVM |
| HW_CPU_X86_SSE |
| COMPUTE_IMAGE_TYPE_ISO |
| COMPUTE_VOLUME_ATTACH_WITH_TAG |
| COMPUTE_VOLUME_EXTEND |
| HW_CPU_X86_MMX |
| COMPUTE_VOLUME_MULTI_ATTACH |
| COMPUTE_NET_ATTACH_INTERFACE_WITH_TAG |
| COMPUTE_IMAGE_TYPE_AKI |
| COMPUTE_IMAGE_TYPE_ARI |
| COMPUTE_IMAGE_TYPE_AMI |
| COMPUTE_DEVICE_TAGGING |
| COMPUTE_IMAGE_TYPE_QCOW2 |
| COMPUTE_NET_ATTACH_INTERFACE |
| COMPUTE_TRUSTED_CERTS |
| CUSTOM_LICENSED_WINDOWS |
+---------------------------------------+

Version of os-traits and Nova
=======================
os-traits:
# pip show os-traits
Name: os-traits
Version: 1.1.0

nova:
# git log
commit ab6834145f3fe1d33ce7f292727a6bc2be50efd9 (HEAD -> stable/train, origin/stable/train)
Merge: 66585e8af1 821506a50c
Author: Zuul <email address hidden>
Date: Mon Oct 21 18:50:20 2019 +0000

    Merge "Fix exception translation when creating volume" into stable/train

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-traits 2.0.0 release.

[Matt Riedemann (mriedem)]

You're also going to need a nova change to update the virt driver interface so the libvirt driver reports the trait.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/698132

[sean mooney (sean-k-mooney)]

this is a valid bug but i am settingits importance to low for two reasons.
first the Virtuozzo ci is not functional anymore so there is no testing of this backend currently.
second as noted in the bug description this only happens if you have set
[scheduler]/query_placement_for_image_type_support=true
as this is currently defaulted to False i would not expect this bug to impact most people
https://github.com/openstack/nova/blob/65aae518f81c2754e30429a3547c5cf62a3cf598/nova/conf/scheduler.py#L181-L183

with that said this is already in progress and i expect that it will be completed sortly.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/698132
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e61cb24932fddd6d5cab9653f833d5f532b7da85
Submitter: Zuul
Branch: master

commit e61cb24932fddd6d5cab9653f833d5f532b7da85
Author: ericxiett <[e-mail]>
Date: Tue Dec 10 03:27:41 2019 +0000

    Report trait 'COMPUTE_IMAGE_TYPE_PLOOP'

    This patch updates virt interface for reporting
    trait 'COMPUTE_IMAGE_TYPE_PLOOP'.

    Change-Id: Ifa2c3857725d64963aed2de7fac0b5b424665afe
    Closes-Bug: #1854235