Renaming vf representors in os-net-config is failing with rhel-7.7 kernel

Bug #1830716 reported by waleed mousa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-net-config
Fix Released
Medium
waleed mousa

Bug Description

When upgrade to rhel-7.7, the phys_port_name for the uplink is not readable
[root@overcloud-computesriov-0 ~]# cat /sys/class/net/p4p1/phys_port_name
cat: /sys/class/net/p4p1/phys_port_name: Operation not supported
And at the rename script we are matching the phys_port_name for the uplink and the vf representors
if [ "$parent_phys_port_name" = "$phys_port_name" ]

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-net-config (master)

Fix proposed to branch: master
Review: https://review.opendev.org/661721

Changed in os-net-config:
assignee: nobody → waleed mousa (waleedm)
status: New → In Progress
Changed in os-net-config:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on os-net-config (master)

Change abandoned by waleed mousa (<email address hidden>) on branch: master
Review: https://review.opendev.org/661721
Reason: This patch is being updated with https://review.opendev.org/#/c/665108/

Changed in os-net-config:
assignee: waleed mousa (waleedm) → Dan Sneddon (dsneddon)
Changed in os-net-config:
assignee: Dan Sneddon (dsneddon) → waleed mousa (waleedm)
Changed in os-net-config:
assignee: waleed mousa (waleedm) → Noam Angel (noama)
Changed in os-net-config:
assignee: Noam Angel (noama) → waleed mousa (waleedm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (master)

Reviewed: https://review.opendev.org/665108
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=5d44b582b514dd91c14c12614a6d003591876054
Submitter: Zuul
Branch: master

commit 5d44b582b514dd91c14c12614a6d003591876054
Author: waleed mousa <email address hidden>
Date: Thu Jun 13 06:33:29 2019 -0400

    Restructuring the method of vf-representor renaming

    The old way of renmaing depended on adding udev rule
    before creating vf-representors and so we faced race condition on
    uplink representor rename.
    So now we are creating vf-representors and after that we adding the
    udev rules and trigerring them at the end
    Also because the old name of UDEV_RULE_FILE(70-persistent-net.rules) is
    used by another module, so we renamed the udev_rule_file to
    (80-persistent-os-net-config.rules) and with that way it will override
    any previouse rules in (70-persistent-net.rules) and will not any cause
    any confustion
    Addition to that, we also added a udev rule to make vf-representors
    unmanaged by NetworkManager in order to be renamed successfully

    Change-Id: I61c59e162bc5d15c063f52612e198d93f4433db1
    Closes-Bug: #1830716

Changed in os-net-config:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-net-config (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/669289

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-net-config (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/669290

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-net-config (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/669291

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (stable/stein)

Reviewed: https://review.opendev.org/669289
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=0f4e67048a8c3f6606256c7c617928f9c47afafa
Submitter: Zuul
Branch: stable/stein

commit 0f4e67048a8c3f6606256c7c617928f9c47afafa
Author: waleed mousa <email address hidden>
Date: Thu Jun 13 06:33:29 2019 -0400

    Restructuring the method of vf-representor renaming

    The old way of renmaing depended on adding udev rule
    before creating vf-representors and so we faced race condition on
    uplink representor rename.
    So now we are creating vf-representors and after that we adding the
    udev rules and trigerring them at the end
    Also because the old name of UDEV_RULE_FILE(70-persistent-net.rules) is
    used by another module, so we renamed the udev_rule_file to
    (80-persistent-os-net-config.rules) and with that way it will override
    any previouse rules in (70-persistent-net.rules) and will not any cause
    any confustion
    Addition to that, we also added a udev rule to make vf-representors
    unmanaged by NetworkManager in order to be renamed successfully

    Change-Id: I61c59e162bc5d15c063f52612e198d93f4433db1
    Closes-Bug: #1830716
    (cherry picked from commit 5d44b582b514dd91c14c12614a6d003591876054)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (stable/rocky)

Reviewed: https://review.opendev.org/669290
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=5a72e4b4a52f8d65ac245159d69d24c7bfb9e427
Submitter: Zuul
Branch: stable/rocky

commit 5a72e4b4a52f8d65ac245159d69d24c7bfb9e427
Author: waleed mousa <email address hidden>
Date: Thu Jun 13 06:33:29 2019 -0400

    Restructuring the method of vf-representor renaming

    The old way of renmaing depended on adding udev rule
    before creating vf-representors and so we faced race condition on
    uplink representor rename.
    So now we are creating vf-representors and after that we adding the
    udev rules and trigerring them at the end
    Also because the old name of UDEV_RULE_FILE(70-persistent-net.rules) is
    used by another module, so we renamed the udev_rule_file to
    (80-persistent-os-net-config.rules) and with that way it will override
    any previouse rules in (70-persistent-net.rules) and will not any cause
    any confustion
    Addition to that, we also added a udev rule to make vf-representors
    unmanaged by NetworkManager in order to be renamed successfully

    Change-Id: I61c59e162bc5d15c063f52612e198d93f4433db1
    Closes-Bug: #1830716
    (cherry picked from commit 5d44b582b514dd91c14c12614a6d003591876054)

tags: added: in-stable-rocky
tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (stable/queens)

Reviewed: https://review.opendev.org/669291
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=bab5da768ba961b7a80edb79b2ca64cbd5da3068
Submitter: Zuul
Branch: stable/queens

commit bab5da768ba961b7a80edb79b2ca64cbd5da3068
Author: waleed mousa <email address hidden>
Date: Thu Jun 13 06:33:29 2019 -0400

    Restructuring the method of vf-representor renaming

    The old way of renmaing depended on adding udev rule
    before creating vf-representors and so we faced race condition on
    uplink representor rename.
    So now we are creating vf-representors and after that we adding the
    udev rules and trigerring them at the end
    Also because the old name of UDEV_RULE_FILE(70-persistent-net.rules) is
    used by another module, so we renamed the udev_rule_file to
    (80-persistent-os-net-config.rules) and with that way it will override
    any previouse rules in (70-persistent-net.rules) and will not any cause
    any confustion
    Addition to that, we also added a udev rule to make vf-representors
    unmanaged by NetworkManager in order to be renamed successfully

    Change-Id: I61c59e162bc5d15c063f52612e198d93f4433db1
    Closes-Bug: #1830716
    (cherry picked from commit 5d44b582b514dd91c14c12614a6d003591876054)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-net-config 11.1.0

This issue was fixed in the openstack/os-net-config 11.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-net-config 10.4.1

This issue was fixed in the openstack/os-net-config 10.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-net-config 9.4.1

This issue was fixed in the openstack/os-net-config 9.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-net-config 8.5.1

This issue was fixed in the openstack/os-net-config 8.5.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.