[RFE] os-net-config should run ethtool commands without restarting interfaces

[Dan Sneddon]

A recent patchset added the ability to modify certain parameters (routes, IP, netmask, MTU) of interfaces without restarting the interface. The same should be possible with ethtool_opts, since these are just ethtool parameters that get run when the interface comes up.

Instead of restarting the interface when the ethtool_opts change, the new options should be written to the ifcfg file and then ethtool should be called with the new options. This will prevent downtime and achieve the same result as restarting the interface.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/os-net-config/+/852527

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/os-net-config/+/852527
Committed: https://opendev.org/openstack/os-net-config/commit/1b2987ca3f66cbdc95b8fa1d8808b01f1b10cce5
Submitter: "Zuul (22348)"
Branch: master

commit 1b2987ca3f66cbdc95b8fa1d8808b01f1b10cce5
Author: Keigo Noha <email address hidden>
Date: Tue Aug 9 17:45:58 2022 +0900

    os-net-config runs ethtool command without restarting interfaces

    Previously, adding or modifying ETHTOOL_OPTS causes restarting
    interfaces. It causes a downtime though ETHTOOL_OPTS can be applied
    without restarting interfaces.
    This change will apply ETHTOOL_OPTS via ethtool command when the option
    is added or modified without restarting interfaces.

    Closes-Bug: #1800237
    Change-Id: I6445685b00ec98788426d0786e78c6d3750c9910

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/os-net-config/+/870909

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/os-net-config/+/870909
Committed: https://opendev.org/openstack/os-net-config/commit/b2e7d956ba8bb619e89cb20b8e1d94d2662ce305
Submitter: "Zuul (22348)"
Branch: stable/zed

commit b2e7d956ba8bb619e89cb20b8e1d94d2662ce305
Author: Keigo Noha <email address hidden>
Date: Tue Aug 9 17:45:58 2022 +0900

    os-net-config runs ethtool command without restarting interfaces

    Previously, adding or modifying ETHTOOL_OPTS causes restarting
    interfaces. It causes a downtime though ETHTOOL_OPTS can be applied
    without restarting interfaces.
    This change will apply ETHTOOL_OPTS via ethtool command when the option
    is added or modified without restarting interfaces.

    Changes from Master branch:
    The bindep.txt file is removed as its already present in stable/zed branch.

    Closes-Bug: #1800237
    Change-Id: I6445685b00ec98788426d0786e78c6d3750c9910
    (cherry picked from commit 1b2987ca3f66cbdc95b8fa1d8808b01f1b10cce5)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/os-net-config/+/877506

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/os-net-config/+/881087

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/os-net-config/+/877506
Committed: https://opendev.org/openstack/os-net-config/commit/0e81aeaf8fe5ed8d0cd5e1da25c383eb9ec9a2a3
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 0e81aeaf8fe5ed8d0cd5e1da25c383eb9ec9a2a3
Author: Keigo Noha <email address hidden>
Date: Tue Aug 9 17:45:58 2022 +0900

    os-net-config runs ethtool command without restarting interfaces

    Previously, adding or modifying ETHTOOL_OPTS causes restarting
    interfaces. It causes a downtime though ETHTOOL_OPTS can be applied
    without restarting interfaces.
    This change will apply ETHTOOL_OPTS via ethtool command when the option
    is added or modified without restarting interfaces.

    Changes from Master branch:
    The bindep.txt file is removed as its already present in stable/zed branch.

    Closes-Bug: #1800237
    Change-Id: I6445685b00ec98788426d0786e78c6d3750c9910
    (cherry picked from commit 1b2987ca3f66cbdc95b8fa1d8808b01f1b10cce5)
    (cherry picked from commit b2e7d956ba8bb619e89cb20b8e1d94d2662ce305)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/os-net-config/+/881087
Committed: https://opendev.org/openstack/os-net-config/commit/ce21f81e32c19fd972c9a7113b3da33b311d1182
Submitter: "Zuul (22348)"
Branch: stable/train

commit ce21f81e32c19fd972c9a7113b3da33b311d1182
Author: Keigo Noha <email address hidden>
Date: Tue Aug 9 17:45:58 2022 +0900

    os-net-config runs ethtool command without restarting interfaces

    Previously, adding or modifying ETHTOOL_OPTS causes restarting
    interfaces. It causes a downtime though ETHTOOL_OPTS can be applied
    without restarting interfaces.
    This change will apply ETHTOOL_OPTS via ethtool command when the option
    is added or modified without restarting interfaces.

    Changes from Master branch:
    The bindep.txt file is removed as its already present in stable/zed branch.

    Closes-Bug: #1800237
    Change-Id: I6445685b00ec98788426d0786e78c6d3750c9910
    (cherry picked from commit 1b2987ca3f66cbdc95b8fa1d8808b01f1b10cce5)
    (cherry picked from commit b2e7d956ba8bb619e89cb20b8e1d94d2662ce305)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-net-config train-eol release.