[RFE] IP, MTU, and route changes should not restart interfaces

Bug #1795129 reported by Dan Sneddon on 2018-09-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-net-config
Undecided
Dan Sneddon

Bug Description

os-net-config restarts an interface when any aspect of the configuration changes. Some changes, like IP changes, route changes, MTU, and boot settings can be set on the fly with 'ip' or 'ip route' commands. If those are the only changes, os-net-config should just make the changes to the config and run the necessary commands instead of restarting the interface.

This behavior is necessary in environments where routes may be updated during scaling operations, such as routed spine/leaf environments when adding new leaf networks.

Dan Sneddon (dsneddon) on 2018-09-29
Changed in os-net-config:
status: New → Triaged
assignee: nobody → Dan Sneddon (dsneddon)
Changed in os-net-config:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/606396
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=c9bf347a238d45072c54d0915e4b9ea0a8683a17
Submitter: Zuul
Branch: master

commit c9bf347a238d45072c54d0915e4b9ea0a8683a17
Author: Dan Sneddon <email address hidden>
Date: Sat Sep 29 04:28:14 2018 -0700

    Apply IP/netmask/route/MTU changes without bouncing interfaces.

    Modifications to impl_ifcfg.py to support making changes to IP
    address, MTU, and routes live, rather than running ifdown/ifup on the
    interface. Bouncing the interface is very disruptive, especially with
    bridges where all the child interfaces are also bounced.

    If only the IP address, netmask, MTU, routes, and/or boot status are
    changed, the file will be written and 'ip' or 'ip route' commands
    will be run to apply the new config on the fly. If any commands fail,
    the interface will be restarted instead.

    Closes-bug: 1795129
    Change-Id: I75239fd3f273a88feb80f09a67aa5a947d64ac30

Changed in os-net-config:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/616992
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=6252d770baa55ca3ab28be8cfd0d5ea50f32bed0
Submitter: Zuul
Branch: stable/rocky

commit 6252d770baa55ca3ab28be8cfd0d5ea50f32bed0
Author: Dan Sneddon <email address hidden>
Date: Sat Sep 29 04:28:14 2018 -0700

    Apply IP/netmask/route/MTU changes without bouncing interfaces.

    Modifications to impl_ifcfg.py to support making changes to IP
    address, MTU, and routes live, rather than running ifdown/ifup on the
    interface. Bouncing the interface is very disruptive, especially with
    bridges where all the child interfaces are also bounced.

    If only the IP address, netmask, MTU, routes, and/or boot status are
    changed, the file will be written and 'ip' or 'ip route' commands
    will be run to apply the new config on the fly. If any commands fail,
    the interface will be restarted instead.

    Closes-bug: 1795129
    Change-Id: I75239fd3f273a88feb80f09a67aa5a947d64ac30
    (cherry picked from commit c9bf347a238d45072c54d0915e4b9ea0a8683a17)

tags: added: in-stable-rocky
tags: added: in-stable-queens

Reviewed: https://review.openstack.org/616996
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=d3a0291e39b1ff904e7b587e612442fe57a8d3e9
Submitter: Zuul
Branch: stable/queens

commit d3a0291e39b1ff904e7b587e612442fe57a8d3e9
Author: Dan Sneddon <email address hidden>
Date: Sat Sep 29 04:28:14 2018 -0700

    Apply IP/netmask/route/MTU changes without bouncing interfaces.

    Modifications to impl_ifcfg.py to support making changes to IP
    address, MTU, and routes live, rather than running ifdown/ifup on the
    interface. Bouncing the interface is very disruptive, especially with
    bridges where all the child interfaces are also bounced.

    If only the IP address, netmask, MTU, routes, and/or boot status are
    changed, the file will be written and 'ip' or 'ip route' commands
    will be run to apply the new config on the fly. If any commands fail,
    the interface will be restarted instead.

    Closes-bug: 1795129
    Change-Id: I75239fd3f273a88feb80f09a67aa5a947d64ac30
    (cherry picked from commit c9bf347a238d45072c54d0915e4b9ea0a8683a17)

This issue was fixed in the openstack/os-net-config 10.2.0 release.

This issue was fixed in the openstack/os-net-config 9.3.0 release.

This issue was fixed in the openstack/os-net-config 8.4.4 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers