os-net-config - schema validation on routes fail if routes is []

[Harald Jensås]

When support for routes was added to nic-config templates in Tripleo Heat templates the default is an empty list of routes. I.e []. Ref: https://review.openstack.org/#/c/580236/

os-net-config does not accept an empty list during schema validation. Schema validation fail with:

   items/oneOf/ovs_bridge/routes/minItems: [] is too short

[2018/09/17 04:42:37 PM] [WARNING] Config file failed schema validation at network_config/1:
    {'persist_mapping': False, 'addresses': [{'ip_netmask': '11.0.0.28/24'}], 'nic_mapping': None, 'routes': [], 'use_dhcp': False, 'type': 'interface', 'name': 'eth1'} is not valid under any of the given schemas
  Sub-schemas tested and not matching:
  - items/oneOf/interface/routes/minItems: [] is too short
Config file failed schema validation at network_config/3:
    {'persist_mapping': False, 'addresses': [{'ip_netmask': '12.0.0.34/24'}], 'nic_mapping': None, 'routes': [], 'use_dhcp': False, 'type': 'interface', 'name': 'eth3'} is not valid under any of the given schemas
  Sub-schemas tested and not matching:
  - items/oneOf/interface/routes/minItems: [] is too short

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/603192

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/603192
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=acf646383ba1b5ecb982a0e57e093f841842c396
Submitter: Zuul
Branch: master

commit acf646383ba1b5ecb982a0e57e093f841842c396
Author: Harald Jensås <email address hidden>
Date: Mon Sep 17 19:33:15 2018 +0200

    Allow list_of_routes to be [] in config

    This changes the schema validation to allow an empty
    list of routes to be specified in the configuration.

    Closes-Bug: #1792992
    Change-Id: I808cdd9c352f3e0dd0b75b8b8b738b97d82da7c1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/608386

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/608386
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=bedb54a8a5d5caa5d022b4aa265a35a702e8dd87
Submitter: Zuul
Branch: stable/rocky

commit bedb54a8a5d5caa5d022b4aa265a35a702e8dd87
Author: Harald Jensås <email address hidden>
Date: Mon Sep 17 19:33:15 2018 +0200

    Allow list_of_routes to be [] in config

    This changes the schema validation to allow an empty
    list of routes to be specified in the configuration.

    Closes-Bug: #1792992
    Change-Id: I808cdd9c352f3e0dd0b75b8b8b738b97d82da7c1
    (cherry picked from commit acf646383ba1b5ecb982a0e57e093f841842c396)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-net-config 10.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-net-config 9.3.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/731201

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/731201
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=eacc5d8c05279172f1aaff8e3cf1c13cacbbfca7
Submitter: Zuul
Branch: stable/queens

commit eacc5d8c05279172f1aaff8e3cf1c13cacbbfca7
Author: Harald Jensås <email address hidden>
Date: Mon Sep 17 19:33:15 2018 +0200

    Allow list_of_routes to be [] in config

    This changes the schema validation to allow an empty
    list of routes to be specified in the configuration.

    Closes-Bug: #1792992
    Change-Id: I808cdd9c352f3e0dd0b75b8b8b738b97d82da7c1
    (cherry picked from commit acf646383ba1b5ecb982a0e57e093f841842c396)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-net-config queens-eol release.