os-net-config master fails tests if OVS installed

Bug #1783240 reported by Dan Sneddon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-net-config
Fix Released
High
Dan Sneddon

Bug Description

The latest masters of os-net-config pass tests in CI, but if you run tox on a host with OVS installed, 3 tests fail. This error happens because the code is expecting an error that shows that OVS is not installed, but this error only occurs on a host that doesn't have OVS installed.

============================

os_net_config.tests.test_objects.TestOvsRequiredObjects.test_ovs_bridge
-----------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "os_net_config/tests/test_objects.py", line 1786, in test_ovs_bridge
        json.loads(data))
      File "/home/dsneddon/workspace/os-net-config/.tox/py27/lib/python2.7/site-packages/testtools/testcase.py", line 485, in assertRaises
        self.assertThat(our_callable, matcher)
      File "/home/dsneddon/workspace/os-net-config/.tox/py27/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
        raise mismatch_error
    testtools.matchers._impl.MismatchError: <function from_json at 0x7ff0694397d0> returned <os_net_config.objects.OvsBridge object at 0x7ff068f0e0d0>
=============================

We should stub out the OVS installed test so we can ensure that it always appears that OVS is not installed.

Dan Sneddon (dsneddon)
Changed in os-net-config:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Dan Sneddon (dsneddon)
Changed in os-net-config:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (master)

Reviewed: https://review.openstack.org/585070
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=6641c9f8c0cb69e8495cb4360f50c5e048c50be1
Submitter: Zuul
Branch: master

commit 6641c9f8c0cb69e8495cb4360f50c5e048c50be1
Author: Dan Sneddon <email address hidden>
Date: Mon Jul 23 19:22:44 2018 -0700

    Stub out check for OVS installed to avoid failing tests

    The tests for the method that checks to see if OVS is installed
    only pass if OVS is not installed. This change stubs out the
    function so the tests pass on systems with OVS.

    Closes-bug: #1783240

    Change-Id: I70bee7a7556aada186ccec89dbe800c8eb870aa5

Changed in os-net-config:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-net-config 9.1.0

This issue was fixed in the openstack/os-net-config 9.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.