os-net-config doesn't parse nicX abstractions for dotted VLANs (nic1.100)

Bug #1783206 reported by Dan Sneddon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-net-config
Fix Released
Low
Dan Sneddon

Bug Description

Linux has two ways to configure VLANs, named VLANs (e.g. VLAN100), and dotted VLANs (e.g. eth0.100). os-net-config supports both formats, but the dotted VLAN notation doesn't support numbered NIC abstractions. The nicX numbered NIC abstractions should be available in both formats.

Named VLAN format:

network_config:
  -
    type: interface
    name: nic1
    use_dhcp: true
  -
    type: vlan
    vlan_id: 100
    device: nic1
    use_dhcp: true

Dotted VLAN format:

network_config:
  -
    type: interface
    name: nic1
    use_dhcp: true
  -
    type: interface
    name: eth2.200 # Should support "nic1.200"
    use_dhcp: true

Dan Sneddon (dsneddon)
Changed in os-net-config:
importance: Undecided → Low
assignee: nobody → Dan Sneddon (dsneddon)
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-net-config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/586507

Changed in os-net-config:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (master)

Reviewed: https://review.openstack.org/586507
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=e12837353dc3668da7cfc575777ef197df4b0497
Submitter: Zuul
Branch: master

commit e12837353dc3668da7cfc575777ef197df4b0497
Author: Dan Sneddon <email address hidden>
Date: Fri Jul 27 03:46:34 2018 -0700

    Fix numbered NIC mapping when using dotted VLAN notation

    When declaring VLANs using dotted notation (such as em1.10
    for VLAN 10 on interface em1), numbered NICs are not
    properly mapped to real interface names. This patch fixes
    the handling of the mapped NIC names inside the BaseOpts
    object that is the base class for all interface types.
    This allows an interface name of "nic1.10" to be mapped
    to, e.g. "em1.10"

    Closes-bug: #1783206

    Change-Id: Ibd9b28128900d9e959b82eb8673b8380bf20606a

Changed in os-net-config:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-net-config (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/587826

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-net-config 9.2.0

This issue was fixed in the openstack/os-net-config 9.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (stable/queens)

Reviewed: https://review.openstack.org/587826
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=e771e088c5eada6b9ab0ec5c32fec6fe98d25131
Submitter: Zuul
Branch: stable/queens

commit e771e088c5eada6b9ab0ec5c32fec6fe98d25131
Author: Dan Sneddon <email address hidden>
Date: Fri Jul 27 03:46:34 2018 -0700

    Fix numbered NIC mapping when using dotted VLAN notation

    When declaring VLANs using dotted notation (such as em1.10
    for VLAN 10 on interface em1), numbered NICs are not
    properly mapped to real interface names. This patch fixes
    the handling of the mapped NIC names inside the BaseOpts
    object that is the base class for all interface types.
    This allows an interface name of "nic1.10" to be mapped
    to, e.g. "em1.10"

    Closes-bug: #1783206

    Change-Id: Ibd9b28128900d9e959b82eb8673b8380bf20606a
    (cherry picked from commit e12837353dc3668da7cfc575777ef197df4b0497)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-net-config 8.4.4

This issue was fixed in the openstack/os-net-config 8.4.4 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.