os-net-config

ethernet device sort is string based instead of index based

Bug #1482818 reported by Brian Demers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-net-config
Fix Committed
Undecided
Brian Demers

Bug Description

utils. ordered_active_nics does try to separate embeded devices and traditional ethX from other named devices.

However this results in enp10s0 ordered before enp8s0

A natural/human sort should be used in placed of a string sort.

Impl:
https://github.com/openstack/os-net-config/blob/cb578ed9b94ff9a34b41d91ada94e3375436b60c/os_net_config/utils.py#L78-L89

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-net-config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/210688

Changed in os-net-config:
assignee: nobody → Brian Demers (brian-demers)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (master)

Reviewed: https://review.openstack.org/210688
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=455cabdee3158e7b2181c96e6d3b791f812c7fee
Submitter: Jenkins
Branch: master

commit 455cabdee3158e7b2181c96e6d3b791f812c7fee
Author: bdemers <email address hidden>
Date: Fri Aug 7 23:54:35 2015 -0400

    Added natural sort for interfaces in utils.ordered_active_nics()

    This way device eth10 is after eth9, and not directly after eth1

    Change-Id: I81eba97cccf6c4f314f9037d16ee1f244dbade02
    Closes-Bug: #1482818

Changed in os-net-config:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.