python 2.6 unit test failure TestIfcfgNetConfigApply.test_restart_children_on_change

Bug #1370615 reported by Dan Prince
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-net-config
Fix Released
High
Dan Prince

Bug Description

Seeing the following python 2.6 unit test failure:

2014-09-17 16:36:34.066 | FAIL: os_net_config.tests.test_impl_ifcfg.TestIfcfgNetConfigApply.test_restart_children_on_change
2014-09-17 16:36:34.066 | tags: worker-3
2014-09-17 16:36:34.066 | ----------------------------------------------------------------------
2014-09-17 16:36:34.066 | Traceback (most recent call last):
2014-09-17 16:36:34.067 | _StringException: Empty attachments:
2014-09-17 16:36:34.067 | stderr
2014-09-17 16:36:34.067 | stdout
2014-09-17 16:36:34.068 |
2014-09-17 16:36:34.068 | pythonlogging:'': {{{
2014-09-17 16:36:34.068 | Ifcfg net config provider created.
2014-09-17 16:36:34.069 | adding interface: em1
2014-09-17 16:36:34.069 | adding bridge: br-ctlplane
2014-09-17 16:36:34.069 | applying network configs...
2014-09-17 16:36:34.069 | No changes required for interface: em1
2014-09-17 16:36:34.070 | No changes required for bridge: br-ctlplane
2014-09-17 16:36:34.070 | running ifdown on interface: em1
2014-09-17 16:36:34.070 | running ifdown on interface: em1
2014-09-17 16:36:34.071 | running ifdown on interface: em1
2014-09-17 16:36:34.071 | running ifdown on bridge: br-ctlplane
2014-09-17 16:36:34.071 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmp6h8IaD
2014-09-17 16:36:34.072 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmpP95iKy
2014-09-17 16:36:34.072 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmpkfPERN
2014-09-17 16:36:34.072 | running ifup on bridge: br-ctlplane
2014-09-17 16:36:34.072 | running ifup on interface: em1
2014-09-17 16:36:34.073 | running ifup on interface: em1
2014-09-17 16:36:34.073 | running ifup on interface: em1
2014-09-17 16:36:34.073 | adding interface: em1
2014-09-17 16:36:34.074 | adding bridge: br-ctlplane
2014-09-17 16:36:34.074 | applying network configs...
2014-09-17 16:36:34.074 | No changes required for bridge: br-ctlplane
2014-09-17 16:36:34.075 | running ifdown on interface: em1
2014-09-17 16:36:34.075 | running ifdown on bridge: br-ctlplane
2014-09-17 16:36:34.075 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmp6h8IaD
2014-09-17 16:36:34.075 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmpP95iKy
2014-09-17 16:36:34.076 | running ifup on bridge: br-ctlplane
2014-09-17 16:36:34.076 | running ifup on interface: em1
2014-09-17 16:36:34.076 | adding interface: em1
2014-09-17 16:36:34.077 | adding interface: em2
2014-09-17 16:36:34.077 | adding bond: bond0
2014-09-17 16:36:34.077 | adding bridge: br-ctlplane
2014-09-17 16:36:34.078 | applying network configs...
2014-09-17 16:36:34.078 | No changes required for interface: em2
2014-09-17 16:36:34.078 | No changes required for interface: em1
2014-09-17 16:36:34.078 | No changes required for interface: bond0
2014-09-17 16:36:34.078 | No changes required for bridge: br-ctlplane
2014-09-17 16:36:34.078 | running ifdown on interface: em2
2014-09-17 16:36:34.078 | running ifdown on interface: em2
2014-09-17 16:36:34.079 | running ifdown on interface: em1
2014-09-17 16:36:34.079 | running ifdown on interface: em1
2014-09-17 16:36:34.079 | running ifdown on interface: bond0
2014-09-17 16:36:34.079 | running ifdown on interface: em1
2014-09-17 16:36:34.079 | running ifdown on interface: em2
2014-09-17 16:36:34.079 | running ifdown on interface: em1
2014-09-17 16:36:34.080 | running ifdown on interface: em2
2014-09-17 16:36:34.080 | running ifdown on bridge: br-ctlplane
2014-09-17 16:36:34.080 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmp6h8IaD
2014-09-17 16:36:34.081 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmpP95iKy
2014-09-17 16:36:34.081 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmpkfPERN
2014-09-17 16:36:34.081 | running ifup on bridge: br-ctlplane
2014-09-17 16:36:34.081 | running ifup on interface: em2
2014-09-17 16:36:34.082 | running ifup on interface: em2
2014-09-17 16:36:34.082 | running ifup on interface: em1
2014-09-17 16:36:34.082 | running ifup on interface: em1
2014-09-17 16:36:34.083 | running ifup on interface: bond0
2014-09-17 16:36:34.083 | running ifup on interface: em1
2014-09-17 16:36:34.083 | running ifup on interface: em2
2014-09-17 16:36:34.084 | running ifup on interface: em1
2014-09-17 16:36:34.084 | running ifup on interface: em2
2014-09-17 16:36:34.085 | adding interface: em1
2014-09-17 16:36:34.085 | adding interface: em2
2014-09-17 16:36:34.085 | adding bond: bond0
2014-09-17 16:36:34.086 | adding bridge: br-ctlplane
2014-09-17 16:36:34.086 | applying network configs...
2014-09-17 16:36:34.086 | No changes required for interface: em2
2014-09-17 16:36:34.086 | No changes required for interface: em1
2014-09-17 16:36:34.087 | No changes required for bridge: br-ctlplane
2014-09-17 16:36:34.087 | running ifdown on interface: em2
2014-09-17 16:36:34.087 | running ifdown on interface: em2
2014-09-17 16:36:34.088 | running ifdown on interface: em1
2014-09-17 16:36:34.088 | running ifdown on interface: em1
2014-09-17 16:36:34.089 | running ifdown on interface: em1
2014-09-17 16:36:34.089 | running ifdown on interface: em2
2014-09-17 16:36:34.089 | running ifdown on bridge: br-ctlplane
2014-09-17 16:36:34.090 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmp6h8IaD
2014-09-17 16:36:34.090 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmpP95iKy
2014-09-17 16:36:34.090 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmpkfPERN
2014-09-17 16:36:34.091 | running ifup on bridge: br-ctlplane
2014-09-17 16:36:34.091 | running ifup on interface: em2
2014-09-17 16:36:34.091 | running ifup on interface: em2
2014-09-17 16:36:34.092 | running ifup on interface: em1
2014-09-17 16:36:34.092 | running ifup on interface: em1
2014-09-17 16:36:34.092 | running ifup on interface: em1
2014-09-17 16:36:34.093 | running ifup on interface: em2
2014-09-17 16:36:34.093 | }}}
2014-09-17 16:36:34.093 |
2014-09-17 16:36:34.093 | Traceback (most recent call last):
2014-09-17 16:36:34.094 | File "os_net_config/tests/test_impl_ifcfg.py", line 354, in test_restart_children_on_change
2014-09-17 16:36:34.094 | self.assertIn('bond0', self.ifup_interface_names)
2014-09-17 16:36:34.094 | File "/home/jenkins/workspace/gate-os-net-config-python26/.tox/py26/lib/python2.6/site-packages/testtools/testcase.py", line 354, in assertIn
2014-09-17 16:36:34.095 | self.assertThat(haystack, Contains(needle), message)
2014-09-17 16:36:34.095 | File "/home/jenkins/workspace/gate-os-net-config-python26/.tox/py26/lib/python2.6/site-packages/testtools/testcase.py", line 433, in assertThat
2014-09-17 16:36:34.095 | raise mismatch_error
2014-09-17 16:36:34.096 | MismatchError: 'bond0' not in ['br-ctlplane', 'em2', 'em2', 'em1', 'em1', 'em1', 'em2']
2014-09-17 16:36:34.096 |
2014-09-17 16:36:34.096 | Traceback (most recent call last):
2014-09-17 16:36:34.096 | _StringException: Empty attachments:
2014-09-17 16:36:34.097 | stderr
2014-09-17 16:36:34.097 | stdout
2014-09-17 16:36:34.097 |
2014-09-17 16:36:34.098 | pythonlogging:'': {{{
2014-09-17 16:36:34.098 | Ifcfg net config provider created.
2014-09-17 16:36:34.098 | adding interface: em1
2014-09-17 16:36:34.098 | adding bridge: br-ctlplane
2014-09-17 16:36:34.098 | applying network configs...
2014-09-17 16:36:34.098 | No changes required for interface: em1
2014-09-17 16:36:34.099 | No changes required for bridge: br-ctlplane
2014-09-17 16:36:34.099 | running ifdown on interface: em1
2014-09-17 16:36:34.099 | running ifdown on interface: em1
2014-09-17 16:36:34.099 | running ifdown on interface: em1
2014-09-17 16:36:34.099 | running ifdown on bridge: br-ctlplane
2014-09-17 16:36:34.099 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmp6h8IaD
2014-09-17 16:36:34.099 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmpP95iKy
2014-09-17 16:36:34.100 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmpkfPERN
2014-09-17 16:36:34.100 | running ifup on bridge: br-ctlplane
2014-09-17 16:36:34.100 | running ifup on interface: em1
2014-09-17 16:36:34.100 | running ifup on interface: em1
2014-09-17 16:36:34.100 | running ifup on interface: em1
2014-09-17 16:36:34.100 | adding interface: em1
2014-09-17 16:36:34.100 | adding bridge: br-ctlplane
2014-09-17 16:36:34.101 | applying network configs...
2014-09-17 16:36:34.101 | No changes required for bridge: br-ctlplane
2014-09-17 16:36:34.101 | running ifdown on interface: em1
2014-09-17 16:36:34.101 | running ifdown on bridge: br-ctlplane
2014-09-17 16:36:34.101 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmp6h8IaD
2014-09-17 16:36:34.101 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmpP95iKy
2014-09-17 16:36:34.101 | running ifup on bridge: br-ctlplane
2014-09-17 16:36:34.102 | running ifup on interface: em1
2014-09-17 16:36:34.102 | adding interface: em1
2014-09-17 16:36:34.102 | adding interface: em2
2014-09-17 16:36:34.102 | adding bond: bond0
2014-09-17 16:36:34.102 | adding bridge: br-ctlplane
2014-09-17 16:36:34.103 | applying network configs...
2014-09-17 16:36:34.103 | No changes required for interface: em2
2014-09-17 16:36:34.103 | No changes required for interface: em1
2014-09-17 16:36:34.103 | No changes required for interface: bond0
2014-09-17 16:36:34.103 | No changes required for bridge: br-ctlplane
2014-09-17 16:36:34.103 | running ifdown on interface: em2
2014-09-17 16:36:34.103 | running ifdown on interface: em2
2014-09-17 16:36:34.104 | running ifdown on interface: em1
2014-09-17 16:36:34.104 | running ifdown on interface: em1
2014-09-17 16:36:34.104 | running ifdown on interface: bond0
2014-09-17 16:36:34.104 | running ifdown on interface: em1
2014-09-17 16:36:34.104 | running ifdown on interface: em2
2014-09-17 16:36:34.104 | running ifdown on interface: em1
2014-09-17 16:36:34.104 | running ifdown on interface: em2
2014-09-17 16:36:34.105 | running ifdown on bridge: br-ctlplane
2014-09-17 16:36:34.105 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmp6h8IaD
2014-09-17 16:36:34.105 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmpP95iKy
2014-09-17 16:36:34.105 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmpkfPERN
2014-09-17 16:36:34.105 | running ifup on bridge: br-ctlplane
2014-09-17 16:36:34.105 | running ifup on interface: em2
2014-09-17 16:36:34.106 | running ifup on interface: em2
2014-09-17 16:36:34.106 | running ifup on interface: em1
2014-09-17 16:36:34.106 | running ifup on interface: em1
2014-09-17 16:36:34.106 | running ifup on interface: bond0
2014-09-17 16:36:34.107 | running ifup on interface: em1
2014-09-17 16:36:34.107 | running ifup on interface: em2
2014-09-17 16:36:34.107 | running ifup on interface: em1
2014-09-17 16:36:34.108 | running ifup on interface: em2
2014-09-17 16:36:34.108 | adding interface: em1
2014-09-17 16:36:34.108 | adding interface: em2
2014-09-17 16:36:34.109 | adding bond: bond0
2014-09-17 16:36:34.109 | adding bridge: br-ctlplane
2014-09-17 16:36:34.109 | applying network configs...
2014-09-17 16:36:34.110 | No changes required for interface: em2
2014-09-17 16:36:34.110 | No changes required for interface: em1
2014-09-17 16:36:34.110 | No changes required for bridge: br-ctlplane
2014-09-17 16:36:34.110 | running ifdown on interface: em2
2014-09-17 16:36:34.111 | running ifdown on interface: em2
2014-09-17 16:36:34.111 | running ifdown on interface: em1
2014-09-17 16:36:34.111 | running ifdown on interface: em1
2014-09-17 16:36:34.112 | running ifdown on interface: em1
2014-09-17 16:36:34.112 | running ifdown on interface: em2
2014-09-17 16:36:34.112 | running ifdown on bridge: br-ctlplane
2014-09-17 16:36:34.113 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmp6h8IaD
2014-09-17 16:36:34.113 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmpP95iKy
2014-09-17 16:36:34.113 | writing config file: /tmp/tmp.EXmYJQ3POa/tmppOI8Iv/tmpkfPERN
2014-09-17 16:36:34.113 | running ifup on bridge: br-ctlplane
2014-09-17 16:36:34.114 | running ifup on interface: em2
2014-09-17 16:36:34.114 | running ifup on interface: em2
2014-09-17 16:36:34.114 | running ifup on interface: em1
2014-09-17 16:36:34.115 | running ifup on interface: em1
2014-09-17 16:36:34.115 | running ifup on interface: em1
2014-09-17 16:36:34.115 | running ifup on interface: em2
2014-09-17 16:36:34.115 | }}}
2014-09-17 16:36:34.116 |
2014-09-17 16:36:34.116 | Traceback (most recent call last):
2014-09-17 16:36:34.116 | File "os_net_config/tests/test_impl_ifcfg.py", line 354, in test_restart_children_on_change
2014-09-17 16:36:34.117 | self.assertIn('bond0', self.ifup_interface_names)
2014-09-17 16:36:34.117 | File "/home/jenkins/workspace/gate-os-net-config-python26/.tox/py26/lib/python2.6/site-packages/testtools/testcase.py", line 354, in assertIn
2014-09-17 16:36:34.117 | self.assertThat(haystack, Contains(needle), message)
2014-09-17 16:36:34.118 | File "/home/jenkins/workspace/gate-os-net-config-python26/.tox/py26/lib/python2.6/site-packages/testtools/testcase.py", line 433, in assertThat
2014-09-17 16:36:34.118 | raise mismatch_error
2014-09-17 16:36:34.118 | MismatchError: 'bond0' not in ['br-ctlplane', 'em2', 'em2', 'em1', 'em1', 'em1', 'em2']
2014-09-17 16:36:34.119 | Ran 54 tests in 0.097s
2014-09-17 16:36:34.119 | FAILED (id=0, failures=1)
2014-09-17 16:36:34.120 | error: testr failed (1)
2014-09-17 16:36:34.146 | ERROR: InvocationError: '/home/jenkins/workspace/gate-os-net-config-python26/.tox/py26/bin/python setup.py testr --slowest --testr-args='
2014-09-17 16:36:34.146 | ___________________________________ summary ____________________________________
2014-09-17 16:36:34.146 | ERROR: py26: commands failed
2014-09-17 16:36:34.147 | + result=1
2014-09-17 16:36:34.147 | + echo 'Begin pip freeze output from test virtualenv:'
2014-09-17 16:36:34.148 | Begin pip freeze output from test virtualenv:
2014-09-17 16:36:34.148 | + echo ======================================================================
2014-09-17 16:36:34.148 | ======================================================================

Dan Prince (dan-prince)
Changed in os-net-config:
assignee: nobody → Dan Prince (dan-prince)
importance: Undecided → Critical
status: New → In Progress
importance: Critical → High
Revision history for this message
Dan Prince (dan-prince) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (master)

Reviewed: https://review.openstack.org/122507
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=f457c64bae1e4cca63cd616bfe5e231850838f70
Submitter: Jenkins
Branch: master

commit f457c64bae1e4cca63cd616bfe5e231850838f70
Author: Dan Prince <email address hidden>
Date: Thu Sep 18 15:47:04 2014 -0400

    Update child_members to use a Set

    Updates the impl_ifcfg.child_members method so that it
    uses a set instead of an array (this avoids dups). Also
    fixes an issue with this method which would cause tests
    to fail intermittently due to ordering differences.
    Adding each member object regardless solves this
    (not sure why I had commented out the children.append before)

    Also fixes an issue in test_cli which causes tests to fail
    on Debian which doesn't yet support the add_bond method
    on its ENI provider. This fix was to explicitly set
    --provider=ifcfg on the failing tests. We should be able to
    remove these once ENI supports bonding properly.

    Closes-bug: #1370615

    Change-Id: Id9cfa2b2eaab27c93113956f5956facfa2a2aeee

Changed in os-net-config:
status: In Progress → Fix Committed
Jay Dobies (jdob)
Changed in os-net-config:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.