No need to discover auth uri on guess vm

Bug #1488728 reported by Perry
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-collect-config
Invalid
Undecided
Perry

Bug Description

Looking at project os-collect-config, it changed auth_url to one with no version and then discover auth_url again. Actually there is no any benefit but some problem. First of all, the call to keystone with Discover takes time; Secondly, the Discover always return internal url of keystone - that cause when a public url is needed.

    def __init__(self, auth_url, user_id, password, project_id,
                 keystoneclient=None):
            ...
            auth_url_noneversion = auth_url.replace('/v2.0', '/')
            discover = ks_discover.Discover(auth_url=auth_url_noneversion)
            v3_auth_url = discover.url_for('3.0')
            ....

Revision history for this message
Perry (panxia6679) wrote :

The exact code place is os-collect-config/keystone.py

Changed in openstack-community:
assignee: nobody → Perry (panxia6679)
Perry (panxia6679)
affects: openstack-community → os-collect-config
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-collect-config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/217066

Changed in os-collect-config:
status: New → In Progress
Revision history for this message
Perry (panxia6679) wrote :

I marked this defect as invalid as I realized that the keystone.py replies on keystone discovery to get admin url of keystone. Removing usage of discovery has impact to many unit testing cases.

Instead I will seek for a workaround on my side to workaround the problem.

Changed in os-collect-config:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on os-collect-config (master)

Change abandoned by Dan Prince (<email address hidden>) on branch: master
Review: https://review.openstack.org/217066
Reason: Closing as the associated but was marked invalid.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.