Unconfigured collectors should not be logged as a warning.

Bug #1321551 reported by Clint Byrum
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-collect-config
Fix Released
Medium
Clint Byrum

Bug Description

Currently we get a warning if we don't configure the heat collector. This is really because we have two redundant default collectors, cfn and heat. Once the heat method is at least as performant as the cfn method, we should drop cfn.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-collect-config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/94527

Changed in os-collect-config:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-collect-config (master)

Reviewed: https://review.openstack.org/94527
Committed: https://git.openstack.org/cgit/openstack/os-collect-config/commit/?id=6b478e9d90bce18b03f5411822897740f68c3dd0
Submitter: Jenkins
Branch: master

commit 6b478e9d90bce18b03f5411822897740f68c3dd0
Author: Clint Byrum <email address hidden>
Date: Tue May 20 21:18:24 2014 -0700

    Make heat the default collection method

    Previously we were relying on the CFN compatibility API. This makes the
    native Heat version the default.

    Note that we want to keep full coverage, which is why we are explicitly
    adding cfn back in during tests.

    Change-Id: I5adedd052827e176e2f39071c719600df62019d7
    Closes-Bug: #1321551

Changed in os-collect-config:
status: In Progress → Fix Committed
Revision history for this message
Clint Byrum (clint-fewbar) wrote : Re: We should have only one default: cfn or heat

This had to be reverted. It will break CFN signal type users.

Changed in os-collect-config:
status: Fix Committed → Triaged
status: Triaged → In Progress
summary: - We should have only one default: cfn or heat
+ Unconfigured collectors should not be logged as a warning.
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-collect-config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/105594

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-collect-config (master)

Reviewed: https://review.openstack.org/105594
Committed: https://git.openstack.org/cgit/openstack/os-collect-config/commit/?id=79efeba4c30323a7fceb4dd87b2966d9f037d84b
Submitter: Jenkins
Branch: master

commit 79efeba4c30323a7fceb4dd87b2966d9f037d84b
Author: Clint Byrum <email address hidden>
Date: Tue Jul 8 14:13:37 2014 -0700

    Do not log unconfigured collector as warning

    The configuration will dictate whether or not something is configured.
    If it is not, this is a normal state and should not be logged as a
    warning.

    Change-Id: I479f0aed5837871009bc69fa028f5eb64a060c53
    Closes-Bug: #1321551

Changed in os-collect-config:
status: In Progress → Fix Committed
Jay Dobies (jdob)
Changed in os-collect-config:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.