NVMe-oF cannot connect on newer CentOS 9 stream

Bug #2035811 reported by Gorka Eguileor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-brick
Fix Released
Undecided
Gorka Eguileor

Bug Description

Trying to attach NVMe-oF volumes on newer CentOS 9 stream fails.
Kernel modules are version 5.14.0-354

The reason is that the 'address' file in sysfs now has the 'src_addr' information.

Before we had:
   traddr=127.0.0.1,trsvcid=4420 After:

Now we have:
   traddr=127.0.0.1,trsvcid=4420,src_addr=127.0.0.1

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/os-brick/+/895194

Changed in os-brick:
status: New → In Progress
Revision history for this message
Gorka Eguileor (gorka) wrote :

We'll see in the logs things like:

     Skipping ('traddr=127.0.0.1,trsvcid=4420,src_addr=127.0.0.1', 'tcp', 'nqn.2014-08.org.nvmexpress:uuid:ea841a98-444c-4abb-bd99-092b20518542'), not part of portals [('traddr=192.168.121.63,trsvcid=4420', 'tcp', 'nqn.2014-08.org.nvmexpress:uuid:ea841a98-444c-4abb-bd99-092b20518542'), ('traddr=127.0.0.1,trsvcid=4420', 'tcp', 'nqn.2014-08.org.nvmexpress:uuid:ea841a98-444c-4abb-bd99-092b20518542')]

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (master)

Reviewed: https://review.opendev.org/c/openstack/os-brick/+/895194
Committed: https://opendev.org/openstack/os-brick/commit/268b1261ecf142c9ef603af2ff62815f9670e5d0
Submitter: "Zuul (22348)"
Branch: master

commit 268b1261ecf142c9ef603af2ff62815f9670e5d0
Author: Gorka Eguileor <email address hidden>
Date: Tue Sep 12 15:12:12 2023 +0200

    NVME-oF: Fix to support new "address" in sysfs

    Attaching NVMe-oF no longer works in CentosOS 9 stream using nvme 2.4
    and libnvme 1.4.

    The reason is that the 'address' file in sysfs now has the 'src_addr'
    information.

    Before we had:
       traddr=127.0.0.1,trsvcid=4420 After:

    Now we have:
       traddr=127.0.0.1,trsvcid=4420,src_addr=127.0.0.1

    This patch fixes this issue and future proofs for any additional
    information that may be added by parsing the contents and searching for
    the parts we care: destination address and port.

    Closes-Bug: #2035811
    Change-Id: I7a33f38fb1b215dd23e2cff3ffa79025cf19def7

Changed in os-brick:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/os-brick/+/905231

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 6.6.0

This issue was fixed in the openstack/os-brick 6.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/os-brick/+/905231
Committed: https://opendev.org/openstack/os-brick/commit/05bcadc935fce5a199ccd30ccfe6ed795900112e
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 05bcadc935fce5a199ccd30ccfe6ed795900112e
Author: Gorka Eguileor <email address hidden>
Date: Tue Sep 12 15:12:12 2023 +0200

    NVME-oF: Fix to support new "address" in sysfs

    Attaching NVMe-oF no longer works in CentosOS 9 stream using nvme 2.4
    and libnvme 1.4.

    The reason is that the 'address' file in sysfs now has the 'src_addr'
    information.

    Before we had:
       traddr=127.0.0.1,trsvcid=4420 After:

    Now we have:
       traddr=127.0.0.1,trsvcid=4420,src_addr=127.0.0.1

    This patch fixes this issue and future proofs for any additional
    information that may be added by parsing the contents and searching for
    the parts we care: destination address and port.

    Closes-Bug: #2035811
    Change-Id: I7a33f38fb1b215dd23e2cff3ffa79025cf19def7
    (cherry picked from commit 268b1261ecf142c9ef603af2ff62815f9670e5d0)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/os-brick/+/905992

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/os-brick/+/905992
Committed: https://opendev.org/openstack/os-brick/commit/b1363ca36a34225f4ae6e4e835f504249479dd16
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit b1363ca36a34225f4ae6e4e835f504249479dd16
Author: Gorka Eguileor <email address hidden>
Date: Tue Sep 12 15:12:12 2023 +0200

    NVME-oF: Fix to support new "address" in sysfs

    Attaching NVMe-oF no longer works in CentosOS 9 stream using nvme 2.4
    and libnvme 1.4.

    The reason is that the 'address' file in sysfs now has the 'src_addr'
    information.

    Before we had:
       traddr=127.0.0.1,trsvcid=4420 After:

    Now we have:
       traddr=127.0.0.1,trsvcid=4420,src_addr=127.0.0.1

    This patch fixes this issue and future proofs for any additional
    information that may be added by parsing the contents and searching for
    the parts we care: destination address and port.

    Closes-Bug: #2035811
    Change-Id: I7a33f38fb1b215dd23e2cff3ffa79025cf19def7
    (cherry picked from commit 268b1261ecf142c9ef603af2ff62815f9670e5d0)
    (cherry picked from commit 05bcadc935fce5a199ccd30ccfe6ed795900112e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 6.4.1

This issue was fixed in the openstack/os-brick 6.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 6.2.3

This issue was fixed in the openstack/os-brick 6.2.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.