iSCSI: Flushing issues when multipath config has changed

Bug #1921381 reported by Gorka Eguileor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Wallaby
Fix Released
Critical
Lee Yarwood
Xena
Fix Released
Critical
Lee Yarwood
os-brick
Fix Committed
Critical
Gorka Eguileor
Queens
Triaged
Undecided
Unassigned
Rocky
Triaged
Undecided
Unassigned
Stein
Incomplete
Undecided
Unassigned
Train
Fix Released
Critical
Luigi Toscano
Ussuri
Fix Released
Critical
Luigi Toscano
Victoria
Fix Released
Critical
Sofia Enriquez
Wallaby
Fix Released
Critical
Unassigned
Xena
Fix Released
Critical
Gorka Eguileor

Bug Description

OS-Brick disconnect_volume code assumes that the use_multipath parameter that is used to instantiate the connector has the same value than the connector that was used on the original connect_volume call.

Unfortunately this is not necessarily true, because Nova can attach a volume, then its multipath configuration can be enabled or disabled, and then a detach can be issued.

This leads to a series of serious issues such as:

- Not flushing the single path on disconnect_volume (possible data loss) and leaving it as a leftover device on the host when Nova calls terminate-connection on Cinder.
- Not flushing the multipath device (possible data loss) and leaving it as a lefover device similarly to the other case.

Gorka Eguileor (gorka)
summary: - Flushing issues when multipath config has changed
+ iSCSI: Flushing issues when multipath config has changed
Revision history for this message
Gorka Eguileor (gorka) wrote :

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/os-brick/+/782992

Changed in os-brick:
milestone: none → 4.3.1
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 4.3.1

This issue was fixed in the openstack/os-brick 4.3.1 release.

Changed in nova:
status: New → Confirmed
importance: Undecided → Critical
assignee: nobody → Lee Yarwood (lyarwood)
tags: added: wallaby-rc-potential
Revision history for this message
Balazs Gibizer (balazs-gibizer) wrote :

Nova master (Xena) merged the os-brick min version bump in https://review.opendev.org/c/openstack/nova/+/783674
The stable/wallaby os-brick min version bump is in progress in https://review.opendev.org/c/openstack/nova/+/783822

Revision history for this message
Balazs Gibizer (balazs-gibizer) wrote :

The nova stable/wallaby patch has been merged https://review.opendev.org/c/openstack/nova/+/783822 and an RC2 including this fix has been proposed https://review.opendev.org/c/openstack/releases/+/784201

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 4.0.3

This issue was fixed in the openstack/os-brick 4.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 3.0.6

This issue was fixed in the openstack/os-brick 3.0.6 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 2.10.6

This issue was fixed in the openstack/os-brick 2.10.6 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 4.4.0

This issue was fixed in the openstack/os-brick 4.4.0 release.

Lee Yarwood (lyarwood)
no longer affects: nova
tags: added: iscsi multipath
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on os-brick (stable/stein)

Change abandoned by "Brian Rosmaita <email address hidden>" on branch: stable/stein
Review: https://review.opendev.org/c/openstack/os-brick/+/785383
Reason: Stein transitioned to End of Life by change Icf9a539a7b8b and is accepting no more changes.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.