scsi disk path changed for fiber channel on arm64

Bug #1862443 reported by norman shen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-brick
Fix Released
Undecided
Unassigned

Bug Description

scsi disk path name change on arm 64 device, so https://github.com/openstack/os-brick/blob/e883a6544466c37e8a3639751351cbceec404ef0/os_brick/initiator/connectors/fibre_channel.py#L283 this code is not working.

the new name looks like this (notice the new prefix)

root@compute01:~# ll /dev/disk/by-path/
total 0
drwxr-xr-x 2 root root 260 Feb 7 08:52 ./
drwxr-xr-x 6 root root 120 Dec 23 16:05 ../
lrwxrwxrwx 1 root root 9 Dec 23 16:05 platform-80040000000.peu0-c0-pci-0000:0e:00.0-ata-1 -> ../../sda
lrwxrwxrwx 1 root root 9 Dec 23 16:05 platform-80040000000.peu0-c0-pci-0000:0e:00.0-ata-2 -> ../../sr0
lrwxrwxrwx 1 root root 9 Dec 23 16:05 platform-80040000000.peu0-c0-pci-0000:10:00.0-scsi-0:2:0:0 -> ../../sdb
lrwxrwxrwx 1 root root 10 Dec 23 16:05 platform-80040000000.peu0-c0-pci-0000:10:00.0-scsi-0:2:0:0-part1 -> ../../sdb1
lrwxrwxrwx 1 root root 10 Dec 23 16:05 platform-80040000000.peu0-c0-pci-0000:10:00.0-scsi-0:2:0:0-part2 -> ../../sdb2
lrwxrwxrwx 1 root root 10 Dec 23 16:05 platform-80040000000.peu0-c0-pci-0000:10:00.0-scsi-0:2:0:0-part3 -> ../../sdb3
lrwxrwxrwx 1 root root 10 Dec 23 16:17 platform-80040000000.peu0-c0-pci-0000:10:00.0-scsi-0:2:0:0-part5 -> ../../sdb5
lrwxrwxrwx 1 root root 9 Feb 7 08:52 platform-80040000000.peu0-c0-pci-0000:12:00.0-fc-0x56c92bfa002141e8-lun-0 -> ../../sdd
lrwxrwxrwx 1 root root 9 Feb 7 08:52 platform-80040000000.peu0-c0-pci-0000:12:00.0-fc-0x56c92bfa002141e9-lun-0 -> ../../sdc
lrwxrwxrwx 1 root root 9 Feb 7 08:52 platform-80040000000.peu0-c0-pci-0000:12:00.1-fc-0x56c92bfa002141e8-lun-0 -> ../../sdf
lrwxrwxrwx 1 root root 9 Feb 7 08:52 platform-80040000000.peu0-c0-pci-0000:12:00.1-fc-0x56c92bfa002141e9-lun-0 -> ../../sde

norman shen (jshen28)
summary: - scsi disk path name changed for fiber channel on arm64
+ scsi disk path changed for fiber channel on arm64
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (master)

Reviewed: https://review.opendev.org/706780
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=7c9020f00689220e2815fac9cf067f78dabeaf5e
Submitter: Zuul
Branch: master

commit 7c9020f00689220e2815fac9cf067f78dabeaf5e
Author: shenjiatong <email address hidden>
Date: Mon Feb 10 16:35:15 2020 +0800

    prepend platform info to by-path string

    By default, udev will set device by-path name to its ID_PATH.

    Looking at [1], most of the time, current code works,
    but when system uses platform, then disk name will be prefixed by
    'platform-xxxxx'.

    [1]: https://github.com/systemd/systemd/blob/a0be5386168a39337d879a9f7d4bd224a42250f2/src/udev/udev-builtin-path_id.c#L530

    Change-Id: I9b2c120f074f60b9af6dd81718a5287656040aba
    Closes-Bug: #1862443

Changed in os-brick:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/745243

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (stable/ussuri)

Reviewed: https://review.opendev.org/745243
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=9491b6a417cf0ea129f54ea0bebd59443f9b2ed0
Submitter: Zuul
Branch: stable/ussuri

commit 9491b6a417cf0ea129f54ea0bebd59443f9b2ed0
Author: shenjiatong <email address hidden>
Date: Mon Feb 10 16:35:15 2020 +0800

    prepend platform info to by-path string

    By default, udev will set device by-path name to its ID_PATH.

    Looking at [1], most of the time, current code works,
    but when system uses platform, then disk name will be prefixed by
    'platform-xxxxx'.

    [1]: https://github.com/systemd/systemd/blob/a0be5386168a39337d879a9f7d4bd224a42250f2/src/udev/udev-builtin-path_id.c#L530

    Change-Id: I9b2c120f074f60b9af6dd81718a5287656040aba
    Closes-Bug: #1862443
    (cherry picked from commit 7c9020f00689220e2815fac9cf067f78dabeaf5e)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/751924

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 3.0.4

This issue was fixed in the openstack/os-brick 3.0.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 2.10.6

This issue was fixed in the openstack/os-brick 2.10.6 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.