Windows support broken due to unavailable module

Bug #1850109 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-brick
Fix Released
Undecided
Lucian Petrut

Bug Description

For backwards compatibility reasons, os-brick imports all the connectors, exposing them by the class name[1].

The issue is that one of the connectors, the scaleio one, is no longer importable on Windows. A recent patch[2] is using ioctl calls through the fcntl module, which isn't available on Windows[3].

[1] https://github.com/openstack/os-brick/blob/2d694361fe66736c59ca96a2a54c368638445de6/os_brick/initiator/connector.py#L182-L187
[2] Ifc4dee0a51bafd6aa9865ec66c46c10087daa667
[3] http://paste.openstack.org/raw/785601/

description: updated
Revision history for this message
Lucian Petrut (petrutlucian94) wrote :
Changed in os-brick:
assignee: nobody → Lucian Petrut (petrutlucian94)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (master)

Reviewed: https://review.opendev.org/691626
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=9e8657dd6ef781d7e6027625fc2f05442256c6ac
Submitter: Zuul
Branch: master

commit 9e8657dd6ef781d7e6027625fc2f05442256c6ac
Author: Lucian Petrut <email address hidden>
Date: Tue Oct 29 20:50:02 2019 +0200

    Split connector list by platform

    We'll keep separate lists of connectors for each of the supported
    operating systems so that we don't end up trying to use unsupported
    connectors.

    Since Cinder is explicitly trying to use the iSCSI/FC connectors,
    we'll have to include those as well, for now.

    Change-Id: Ibec2b798e8c5c3457cebea12cfd2f5813e62fb9e
    Closes-Bug: #1850109

Changed in os-brick:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 2.11.0

This issue was fixed in the openstack/os-brick 2.11.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/706190

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/706191

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (stable/train)

Reviewed: https://review.opendev.org/706190
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=0927b72f685df52e632fa6bbe995e0549f6fca02
Submitter: Zuul
Branch: stable/train

commit 0927b72f685df52e632fa6bbe995e0549f6fca02
Author: Lucian Petrut <email address hidden>
Date: Tue Oct 29 20:50:02 2019 +0200

    Split connector list by platform

    We'll keep separate lists of connectors for each of the supported
    operating systems so that we don't end up trying to use unsupported
    connectors.

    Since Cinder is explicitly trying to use the iSCSI/FC connectors,
    we'll have to include those as well, for now.

    Change-Id: Ibec2b798e8c5c3457cebea12cfd2f5813e62fb9e
    Closes-Bug: #1850109
    (cherry picked from commit 9e8657dd6ef781d7e6027625fc2f05442256c6ac)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (stable/stein)

Reviewed: https://review.opendev.org/706191
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=faae6ccdf6c379ce51c902bef96d176688ff4b2b
Submitter: Zuul
Branch: stable/stein

commit faae6ccdf6c379ce51c902bef96d176688ff4b2b
Author: Lucian Petrut <email address hidden>
Date: Tue Oct 29 20:50:02 2019 +0200

    Split connector list by platform

    We'll keep separate lists of connectors for each of the supported
    operating systems so that we don't end up trying to use unsupported
    connectors.

    Since Cinder is explicitly trying to use the iSCSI/FC connectors,
    we'll have to include those as well, for now.

    (cherry picked from commit 9e8657dd6ef781d7e6027625fc2f05442256c6ac)
    (cherry picked from commit 0927b72f685df52e632fa6bbe995e0549f6fca02)

    Change-Id: Ibec2b798e8c5c3457cebea12cfd2f5813e62fb9e
    Closes-Bug: #1850109

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 2.10.2

This issue was fixed in the openstack/os-brick 2.10.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 2.8.4

This issue was fixed in the openstack/os-brick 2.8.4 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.