tox bindep environment looks for 'test' profile only

[Brian Rosmaita]

Observed this while testing out the pdf-docs generation patch.

Suppose I ask tox to check my bindeps for the 'doc' profile:

$ tox -e bindep -- doc
bindep installed: bindep==2.8.1,distro==1.4.0,os-brick==2.9.2.dev6,Parsley==1.3,pbr==5.4.2
bindep run-test-pre: PYTHONHASHSEED='1020640064'
bindep runtests: commands[0] | bindep test
______________ summary _________________________
  bindep: commands succeeded
  congratulations :)

It says everything is fine. But everything is not fine, I am missing some bindeps. You can tell if you run bindep directly:

$ .tox/bindep/bin/bindep doc
Missing packages:
    python3-sphinxcontrib-svg2pdfconverter-common texlive texlive-capt-of texlive-fncychap texlive-framed texlive-needspace texlive-polyglossia texlive-tabulary texlive-titlesec texlive-upquote texlive-wrapfig

The problem is that the bindep tox env is hard-coded to always select the 'test' profile. This makes it useless for testing any other profile.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/679124
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=a8ee3a1b00564cd5585f7b532aea2aabd1f1bd5a
Submitter: Zuul
Branch: master

commit a8ee3a1b00564cd5585f7b532aea2aabd1f1bd5a
Author: Brian Rosmaita <email address hidden>
Date: Wed Aug 28 15:13:12 2019 -0400

    Fix tox 'bindep' environment

    tox.ini is hard-coded to always use the 'test' profile for bindep;
    instead, let tox get the profile from the posargs

    Closes-bug: #1841836
    Change-Id: I24bfb313cf28b20037f5f9aea9417bc8371bfd91

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-brick 2.11.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/679119
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0eab57ebfe3ab721462eb288a43d3b90cc23eda9
Submitter: Zuul
Branch: master

commit 0eab57ebfe3ab721462eb288a43d3b90cc23eda9
Author: Brian Rosmaita <email address hidden>
Date: Wed Aug 28 15:08:22 2019 -0400

    Fix tox 'bindep' environment

    tox.ini is hard-coded to always use the 'test' profile for bindep;
    instead, let tox get the profile from the posargs

    Closes-bug: #1841836
    Change-Id: I24bfb313cf28b20037f5f9aea9417bc8371bfd91

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 16.0.0.0b1 development milestone.