The validation of iscsi session should be case insensitive since IPv6 address may contain lower or upper cases
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
os-brick |
Fix Released
|
Undecided
|
Yong Huang |
Bug Description
If the portal address are lower cases, and the portal address get from 'iscsiadm -m session' contain upper cases, the validation of iscsi session will failed, and can not jump out of the loop
-------
while True:
# Duplicate logins crash iscsiadm after load, so we scan active
# sessions to see if the node is logged in.
for s in sessions:
# Found our session, return session_id
if (s[0] in self.VALID_
-------
So the validation of target address should be case insensitive since IPv6 address is case insensitive
Changed in os-brick: | |
assignee: | nobody → Yong Huang (yonghuang) |
Reviewed: https:/ /review. openstack. org/604253 /git.openstack. org/cgit/ openstack/ os-brick/ commit/ ?id=8782c4accfe a8a745676517c18 80810cfa07feac
Committed: https:/
Submitter: Zuul
Branch: master
commit 8782c4accfea8a7 45676517c188081 0cfa07feac
Author: Yong Huang <email address hidden>
Date: Thu Sep 20 16:26:57 2018 -0400
The validation of iscsi session should be case insensitive
The validation of iscsi session should be case insensitive since IPv6
address is case insensitive. If the portal address are all lower cases,
and the address get from 'iscsiadm -m session' contain upper cases,
the validation of iscsi session will failed, the loop will be endless.
Change-Id: Ief5108e40f13cc 53d8d9e9c5d1a50 54f58f72aa0
Closes-bug: #1793627