Enforce multipath fails because multipathd doesn't return error code

[Gorka Eguileor]

There is a case where `multipathd show status` should fail, yet it doesn't exit with an error code. Instead it returns 0. Error is printed to stdout as "error receiving packet".

This means that enforce will not work as expected.

The multipathd error got fixed here: https://www.redhat.com/archives/dm-devel/2015-March/msg00136.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/597607

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/597607
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=028af871de8a3f45f4cc8342e92d5586a7058e5a
Submitter: Zuul
Branch: master

commit 028af871de8a3f45f4cc8342e92d5586a7058e5a
Author: Gorka Eguileor <email address hidden>
Date: Wed Aug 29 19:16:58 2018 +0200

    Improve detection of multipathd running

    There is a case where `multipathd show status` should fail, yet it
    doesn't exit with an error code. Instead it returns 0. Error is printed
    to stdout as "error receiving packet".

    This means that enforce will not work as expected.

    The multipathd error got fixed here:
    https://www.redhat.com/archives/dm-devel/2015-March/msg00136.html

    But that patch is missing in some packages, so this patch adds a
    workaround to detect the error base on the stdout of the multipathd show
    status command.

    Closes-Bug: #1789699
    Change-Id: I1cb29782541e3fe53b0b1744ab36f56464cd2135

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/603108

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/603108
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=f2fed213f6b1d36513504d0ec4ebbfeeddc52b94
Submitter: Zuul
Branch: stable/rocky

commit f2fed213f6b1d36513504d0ec4ebbfeeddc52b94
Author: Gorka Eguileor <email address hidden>
Date: Wed Aug 29 19:16:58 2018 +0200

    Improve detection of multipathd running

    There is a case where `multipathd show status` should fail, yet it
    doesn't exit with an error code. Instead it returns 0. Error is printed
    to stdout as "error receiving packet".

    This means that enforce will not work as expected.

    The multipathd error got fixed here:
    https://www.redhat.com/archives/dm-devel/2015-March/msg00136.html

    But that patch is missing in some packages, so this patch adds a
    workaround to detect the error base on the stdout of the multipathd show
    status command.

    Closes-Bug: #1789699
    Change-Id: I1cb29782541e3fe53b0b1744ab36f56464cd2135
    (cherry picked from commit 028af871de8a3f45f4cc8342e92d5586a7058e5a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-brick 2.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-brick 2.5.4 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/647783

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/647809

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/647783
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=ce72e77959a6834620793dc9d4006432781d09d7
Submitter: Zuul
Branch: stable/queens

commit ce72e77959a6834620793dc9d4006432781d09d7
Author: Gorka Eguileor <email address hidden>
Date: Wed Aug 29 19:16:58 2018 +0200

    Improve detection of multipathd running

    There is a case where `multipathd show status` should fail, yet it
    doesn't exit with an error code. Instead it returns 0. Error is printed
    to stdout as "error receiving packet".

    This means that enforce will not work as expected.

    The multipathd error got fixed here:
    https://www.redhat.com/archives/dm-devel/2015-March/msg00136.html

    But that patch is missing in some packages, so this patch adds a
    workaround to detect the error base on the stdout of the multipathd show
    status command.

    Closes-Bug: #1789699
    Change-Id: I1cb29782541e3fe53b0b1744ab36f56464cd2135
    (cherry picked from commit 028af871de8a3f45f4cc8342e92d5586a7058e5a)
    (cherry picked from commit f2fed213f6b1d36513504d0ec4ebbfeeddc52b94)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/647809
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=05e60a9d0711c2dd74b2fd20274fdac62effc49f
Submitter: Zuul
Branch: stable/pike

commit 05e60a9d0711c2dd74b2fd20274fdac62effc49f
Author: Gorka Eguileor <email address hidden>
Date: Wed Aug 29 19:16:58 2018 +0200

    Improve detection of multipathd running

    There is a case where `multipathd show status` should fail, yet it
    doesn't exit with an error code. Instead it returns 0. Error is printed
    to stdout as "error receiving packet".

    This means that enforce will not work as expected.

    The multipathd error got fixed here:
    https://www.redhat.com/archives/dm-devel/2015-March/msg00136.html

    But that patch is missing in some packages, so this patch adds a
    workaround to detect the error base on the stdout of the multipathd show
    status command.

    Closes-Bug: #1789699
    Change-Id: I1cb29782541e3fe53b0b1744ab36f56464cd2135
    (cherry picked from commit 028af871de8a3f45f4cc8342e92d5586a7058e5a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-brick 1.15.9 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-brick 2.3.7 release.