Windows connectors have wrong method signature
Bug #1738390 reported by
Lucian Petrut
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| os-brick |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
The Windows connectors do not include the 'device_info' argument in the 'disconnect_volume' method.
This wasn't an issue for Nova as the Hyper-V driver doesn't pass this argument, yet Cinder does pass it, which will lead to an exception.
| Changed in os-brick: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to os-brick (master) | #1 |
| Changed in os-brick: | |
| status: | Confirmed → Fix Released |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix included in openstack/os-brick 2.4.0 | #2 |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 603d036ff93add6
Author: Lucian Petrut <email address hidden>
Date: Fri Dec 15 12:16:52 2017 +0200
Windows: fix connectors 'disconnect_volume' signature
The Windows connectors do not include the 'device_info' argument
in the 'disconnect_volume' method.
This wasn't an issue for Nova as the Hyper-V driver doesn't pass
this argument, yet Cinder does pass it, which will lead to an
exception.
This change adds the missing argument, defaulting to "None" so that
it won't break the Nova Hyper-V driver.
Change-Id: Iaf8b57c97afc39
Closes-Bug: #1738390