os-brick

Replace assertDictMatch with assertDictEqual method in tests

Bug #1646433 reported by Ivan Kolodyazhny
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Wishlist
Ivan Kolodyazhny
OpenStack Shared File Systems Service (Manila)
Fix Released
Wishlist
Archana Kumari
OpenStack Shared File Systems Service (Manila) xena-2
os-brick
Fix Released
Wishlist
wangxiyuan

Bug Description

assertDictMatch was introduced for Python 2.6 only. Python 2.7+ contains assertDictEqual

Ivan Kolodyazhny (e0ne)
summary: - Remove assertDictMatch method from tests
+ Remove assertDictMatch method in tests
summary: - Remove assertDictMatch method in tests
+ Replace assertDictMatch with assertDictEqual method in tests
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/405258

Changed in cinder:
assignee: nobody → Ivan Kolodyazhny (e0ne)
status: New → In Progress
Ji.Wei (jiwei)
Changed in os-brick:
assignee: nobody → Ji.Wei (jiwei)
OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: Ivan Kolodyazhny (e0ne) → Eric Harney (eharney)
zhaobo (zhaobo6)
Changed in manila:
assignee: nobody → zhaobo (zhaobo6)
OpenStack Infra (hudson-openstack)
Changed in manila:
status: New → In Progress
Revision history for this message
wangxiyuan (wangxiyuan) wrote :

non-client libraries will be release soon. Upload the patch dut to there is no action for a long time in os-brick.

https://review.openstack.org/#/c/413880/

Changed in os-brick:
assignee: Ji.Wei (jiwei) → wangxiyuan (wangxiyuan)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/413901

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/405258
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=dff9fcede54d1dc9fd066923d0d55fddf2d1cd3c
Submitter: Jenkins
Branch: master

commit dff9fcede54d1dc9fd066923d0d55fddf2d1cd3c
Author: Ivan Kolodyazhny <email address hidden>
Date: Thu Dec 1 12:23:17 2016 +0200

    Replace assertDictMatch with assertDictEqual method in tests

    assertDictMatch was introduced for Python 2.6 only. Python 2.7+ contains
    assertDictEqual.

    Closes-Bug: #1646433
    Change-Id: Iffd82226a157da918d45691bb487bbc554b9931a

Changed in cinder:
status: In Progress → Fix Released
Eric Harney (eharney)
Changed in cinder:
assignee: Eric Harney (eharney) → Ivan Kolodyazhny (e0ne)
importance: Undecided → Wishlist
Changed in os-brick:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (master)

Reviewed: https://review.openstack.org/413880
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=73a694ae5470eef753ee27ee2e7f1851c9f8339f
Submitter: Jenkins
Branch: master

commit 73a694ae5470eef753ee27ee2e7f1851c9f8339f
Author: wangxiyuan <email address hidden>
Date: Thu Dec 22 11:10:37 2016 +0800

    Replace assertDictMatch with assertDictEqual

    assertDictMatch was introduced for Python 2.6 only. Python 2.7+
    contains assertDictEqual.

    Change-Id: I4914981029995a28cffa8b39e8757f77890a3c2b
    Closes-bug: #1646433

Changed in os-brick:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 1.9.0

This issue was fixed in the openstack/os-brick 1.9.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 10.0.0.0b3

This issue was fixed in the openstack/cinder 10.0.0.0b3 development milestone.

Goutham Pacha Ravi (gouthamr)
Changed in manila:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila (master)

Change abandoned by Zhenyu Zheng (<email address hidden>) on branch: master
Review: https://review.openstack.org/413867

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by ZhaoBo (<email address hidden>) on branch: master
Review: https://review.openstack.org/413901

OpenStack Infra (hudson-openstack)
Changed in manila:
assignee: zhaobo (zhaobo6) → Rajat Sharma (tajar29)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Tom Barron (<email address hidden>) on branch: master
Review: https://review.openstack.org/509972
Reason: No activity since October last year; feel free to restore, rebase, and address review comments.

Revision history for this message
Jason Grosso (jgrosso) wrote :

Hello all looks like this is an abandoned change / wish list item for manila that has no been looked at in 2 years was this discussed at the PTG in Denver 2019??

Revision history for this message
Tom Barron (tpb) wrote :

Jason, we didn't get to it but you can bring it to the weekly meeting.

Archana Kumari (archanaserver)
Changed in manila:
assignee: Rajat Sharma (tajar29) → Archana Kumari (archanaserver)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/795990

Victoria Martinez de la Cruz (vkmc)
Changed in manila:
milestone: none → xena-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/795990
Committed: https://opendev.org/openstack/manila/commit/8ee8ee15b1158ff9ca7bd045cbbfd8c39a2db1d9
Submitter: "Zuul (22348)"
Branch: master

commit 8ee8ee15b1158ff9ca7bd045cbbfd8c39a2db1d9
Author: songwenping <email address hidden>
Date: Fri May 28 15:40:50 2021 +0800

    Replace assertDictMatch with assertDictEqual method in tests

    assertDictMatch was introduced for Python 2.6 only.
    Python 2.7+ contains assertDictEqual.

    Closes-Bug: #1646433
    Change-Id: I41738cc0bd90656508fc6ff390072b55130cc6fc

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 13.0.0.0rc1

This issue was fixed in the openstack/manila 13.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.