[SRU] ERROR "can't get udev device" when iscsi multipath enabled

Bug #1585940 reported by Peter Wang
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Ubuntu Cloud Archive
Invalid
Undecided
Unassigned
Mitaka
Fix Released
High
Edward Hope-Morley
os-brick
Fix Released
Undecided
Peter Wang
python-os-brick (Ubuntu)
Invalid
Undecided
Unassigned
Xenial
Fix Released
High
Edward Hope-Morley

Bug Description

[Impact]

 * Fallback device detection for multipath connections is currently broken.

[Test Case]

 * Enable cinder/nova multipath but do not make multiple paths available (such that are no /dev/disk/path/by-id/dm* devices)

 * Create a cinder volume and attach to Nova instance

 * Check that volume was attached successfully and that /var/log/nova/nova-compute.log does not display the error mentioned below.

[Regression Potential]

 * None

SUMMARY:
Wrong path used when detecting multipath id

ANALYSE:
when multipath device path was not found via LUN wwn, os-brick would use device path like below:

/dev/disk/by-path/ip-192.168.3.52:3260-iscsi-iqn.1992-04.com.emc:cx.apm00153906536.b5-lun-155

to detect multipath id via 'multipath -l <device path>'

but this cause error:
: can't get udev device

actually, we should use its real path like /dev/sdb, dev/sda to detect the multipath id.

Revision history for this message
Peter Wang (peter.wang) wrote :
Changed in os-brick:
status: New → In Progress
assignee: nobody → Peter Wang (peter.wang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (master)

Reviewed: https://review.openstack.org/324248
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=30f4fc763ea5c7298cd51398fa7464524531140b
Submitter: Jenkins
Branch: master

commit 30f4fc763ea5c7298cd51398fa7464524531140b
Author: Peter Wang <email address hidden>
Date: Thu Jun 2 01:57:01 2016 +0000

    Fix wrong path used in iscsi "multipath -l"

    When iSCSI multipath device path was not found via LUN wwn,
    os-brick would use device path like below:
    /dev/disk/by-path/ip-192.168.3.52:3260-iscsi-iqn.1992-04.com.emc:cx.apm00153906536.b5-lun-155
    to detch multipath id via 'multipath -l'.
    This causes error: "can't get udev device"

    This fix will use path like '/dev/sda' to discover mpath id.

    Change-Id: I1177d846a9f6f28b2276aae2ff91af9d4ea5849e
    Closes-bug: #1585940

Changed in os-brick:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/os-brick 1.5.0

This issue was fixed in the openstack/os-brick 1.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/391225

summary: - ERROR "can't get udev device" when iscsi multipath enabled
+ [SRU] ERROR "can't get udev device" when iscsi multipath enabled
Revision history for this message
Edward Hope-Morley (hopem) wrote :

debdiff is here since LP won't let me attach it right now (getting an Oops) - http://pastebin.ubuntu.com/23388698/

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "fix-1585940-xenial.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Changed in python-os-brick (Ubuntu Xenial):
status: New → Triaged
Changed in cloud-archive:
status: New → Invalid
Changed in python-os-brick (Ubuntu):
status: New → Invalid
Changed in python-os-brick (Ubuntu Xenial):
assignee: nobody → Edward Hope-Morley (hopem)
importance: Undecided → High
Revision history for this message
Brian Murray (brian-murray) wrote :

This upload really should have an ubuntu0.1 version number not 1.2.0-3, so 1.2.0-2ubuntu0.1.

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Peter, or anyone else affected,

Accepted python-os-brick into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-os-brick/1.2.0-2ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in python-os-brick (Ubuntu Xenial):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
James Page (james-page) wrote :

Hello Peter, or anyone else affected,

Accepted python-os-brick into mitaka-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:mitaka-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-mitaka-needed to verification-mitaka-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-mitaka-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-mitaka-needed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (stable/mitaka)

Reviewed: https://review.openstack.org/391225
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=b56ca528dd6a6644992cfc818fad1140b1ab22c2
Submitter: Jenkins
Branch: stable/mitaka

commit b56ca528dd6a6644992cfc818fad1140b1ab22c2
Author: Peter Wang <email address hidden>
Date: Thu Jun 2 01:57:01 2016 +0000

    Fix wrong path used in iscsi "multipath -l"

    When iSCSI multipath device path was not found via LUN wwn,
    os-brick would use device path like below:
    /dev/disk/by-path/ip-192.168.3.52:3260-iscsi-iqn.1992-04.com.emc:cx.apm00153906536.b5-lun-155
    to detch multipath id via 'multipath -l'.
    This causes error: "can't get udev device"

    This fix will use path like '/dev/sda' to discover mpath id.

    Closes-bug: #1585940
    (cherry picked from commit 30f4fc763ea5c7298cd51398fa7464524531140b)
    Change-Id: I1177d846a9f6f28b2276aae2ff91af9d4ea5849e

tags: added: sts-sru
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Verified on xenial mitaka (http://pastebin.ubuntu.com/23527553/).

description: updated
tags: added: verification-done
removed: verification-needed
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Also verified trusty-mitaka (UCA)

tags: added: verification-mitaka-done
removed: verification-mitaka-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-os-brick - 1.2.0-2ubuntu0.1

---------------
python-os-brick (1.2.0-2ubuntu0.1) xenial; urgency=medium

  * d/p/fix-wrong-path-used-in-iscsi-multipath-l.patch: Backport
    fix for ERROR "can't get udev device" when iscsi multipath enabled (LP: #1585940).

 -- Edward Hope-Morley <email address hidden> Mon, 07 Nov 2016 16:40:52 +0100

Changed in python-os-brick (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for python-os-brick has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

tags: added: sts-sru-done
removed: sts-sru
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.