Detach encrypted volume not cleanup volume path

[Wilson Liu]

When we detach a encrypted volume, the volume patch like
'/dev/disk/by-path/pci-0000:0c:00.1-fc-0x20811051720c8bca-lun-1 -> /dev/mapper/pci-0000:0c:00.1-fc-0x20811051720c8bca-lun-1' is not cleanup. This will effect next volume attach.

When detaching a encrypted volume, Nova close the volume via "cryptsetup remove", this operation will remove the patch '/dev/mapper/pci-0000:0c:00.1-fc-0x20811051720c8bca-lun-1' but the symbolic '/dev/disk/by-path/pci-0000:0c:00.1-fc-0x20811051720c8bca-lun-1' still exists there. Then when os-brick try to cleanup the volume patch '/dev/disk/by-path/pci-0000:0c:00.1-fc-0x20811051720c8bca-lun-1', the os.path.exists(path) function return False because the real volume path '/dev/mapper/pci-0000:0c:00.1-fc-0x20811051720c8bca-lun-1' is removed.

[Lee Yarwood (lyarwood)]

Can you provide compute logs or the trace showing the attempted removal of the by-path device?

[Lisa Li (lisali)]

For ISCSIConnector, the path can be recovered by rescan before disconnect_volume:
https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connector.py#L835

And for NFS volumes, it leads to following bug: https://bugs.launchpad.net/nova/+bug/1511255

[Sean McGinnis (sean-mcginnis)]

Closing stale bug. This has be Incomplete status for over 90 days. If this is still an issue please reopen.