Incorrect order when removing Multipath iSCSI Storage Device

Bug #1502999 reported by Gorka Eguileor on 2015-10-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-brick
Undecided
Gorka Eguileor

Bug Description

On the ISCSIConnector when we disconnect a multipath we do it in the wrong order.

Order should be:
- Flush multipath (multipath -f device)
- Flush blockdev devices (blockdev --flushbufs device)
- Remove paths

But now we have:
- Flush blockdev devices (blockdev --flushbufs device)
- Flush multipath (multipath -f device)
- Remove paths

Which is not the right order.

Gorka Eguileor (gorka) on 2015-10-05
Changed in os-brick:
assignee: nobody → Gorka Eguileor (gorka)

Fix proposed to branch: master
Review: https://review.openstack.org/231134

Changed in os-brick:
status: New → In Progress
Walt Boring (walter-boring) wrote :

If you issues a multipath -f before you remove the scsi devices, there is a chance that the multipath daemon will recreate the mpath associations while you are removing the scsi devices. This will leave orphaned mpath devices.

Reviewed: https://review.openstack.org/231134
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=53173f78efef17a8456e09354361d04aa7f7da04
Submitter: Jenkins
Branch: master

commit 53173f78efef17a8456e09354361d04aa7f7da04
Author: Gorka Eguileor <email address hidden>
Date: Mon Oct 5 20:31:38 2015 +0200

    Fix iSCSI multipath cleanup

    Cleanup order for multipath in remove_multipath_device should be:
    - Flush multipath (multipath -f device)
    - Flush blockdev devices (blockdev --flushbufs device)
    - Remove paths

    But now we have:
    - Flush blockdev devices (blockdev --flushbufs device)
    - Flush multipath (multipath -f device)
    - Remove paths

    This patch sets the right order.

    Closes-Bug: #1502999
    backport: liberty
    Change-Id: If9dc8f3450ed473393bdb76fe34d5ab78cf9306c

Changed in os-brick:
status: In Progress → Fix Released

This issue was fixed in the openstack/os-brick 1.6.0 release.

This issue was fixed in the openstack/os-brick 1.6.0 release.

Reviewed: https://review.openstack.org/364428
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=b59e1224c71473b1bd42145a3ef2223a2b5fdbc5
Submitter: Jenkins
Branch: stable/mitaka

commit b59e1224c71473b1bd42145a3ef2223a2b5fdbc5
Author: Gorka Eguileor <email address hidden>
Date: Mon Oct 5 20:31:38 2015 +0200

    Fix iSCSI multipath cleanup

    Cleanup order for multipath in remove_multipath_device should be:
    - Flush multipath (multipath -f device)
    - Flush blockdev devices (blockdev --flushbufs device)
    - Remove paths

    But now we have:
    - Flush blockdev devices (blockdev --flushbufs device)
    - Flush multipath (multipath -f device)
    - Remove paths

    This patch sets the right order.

    Closes-Bug: #1502999
    backport: liberty
    Change-Id: If9dc8f3450ed473393bdb76fe34d5ab78cf9306c

tags: added: in-stable-mitaka
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers