os-brick

Incorrect order when removing Multipath FC Storage Device

Bug #1502979 reported by Gorka Eguileor
20
This bug affects 5 people
Affects Status Importance Assigned to Milestone
os-brick
Fix Released
Undecided
Gorka Eguileor

Bug Description

When fixing bug #1487169 a change in the Storage Device Removal was inadvertently introduced to Fibre Channel connector and the order for a clean device removal was altered.

Order should be:
- Flush multipath (multipath -f device)
- Flush blockdev devices (blockdev --flushbufs device)
- Remove paths

But now we have:
- Flush blockdev devices (blockdev --flushbufs device)
- Flush multipath (multipath -f device)
- Remove paths

Which is not the right order.

See original description
Gorka Eguileor (gorka)
Changed in os-brick:
assignee: nobody → Gorka Eguileor (gorka)
Gorka Eguileor (gorka)
description: updated
Gorka Eguileor (gorka)
summary: - Incorrect order when removing Multipath Storage Device
+ Incorrect order when removing Multipath FC Storage Device
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (master)

Fix proposed to branch: master
Review: https://review.openstack.org/231135

Changed in os-brick:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on os-brick (master)

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/231135
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (master)

Reviewed: https://review.openstack.org/231135
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=d937f64af2ea4a9747725061d5b558c6c38a09f6
Submitter: Jenkins
Branch: master

commit d937f64af2ea4a9747725061d5b558c6c38a09f6
Author: Gorka Eguileor <email address hidden>
Date: Mon Oct 5 20:17:20 2015 +0200

    Fix FC multipath cleanup

    Cleanup order for multipath should be:
    - Flush multipath (multipath -f device)
    - Flush blockdev devices (blockdev --flushbufs device)
    - Remove paths

    But now we have:
    - Flush blockdev devices (blockdev --flushbufs device)
    - Flush multipath (multipath -f device)
    - Remove paths

    This patch sets the right order and adds a test to avoid regression.

    Closes-Bug: #1502979
    Change-Id: I065a79514e0fcaf722f57e2edd6f18f31878c711

Changed in os-brick:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/os-brick 1.6.0

This issue was fixed in the openstack/os-brick 1.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/os-brick 1.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/364429

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on os-brick (stable/mitaka)

Change abandoned by Gorka Eguileor (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/364429
Reason: No love from community :'-(

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.