TrItemSData/SData1 Comment
Bug #2038756 reported by
David Webb
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Open Rails |
Fix Committed
|
Low
|
cjakeman | ||
Bug Description
Not really a bug but a suggestion for an improved description for the TrItemSData/SData1 variable. At moment it is descried in Orts.Formats.
/// <summary>Extra data 1, related to location along section</summary>
That is a bit weak. When set it gives the distance of a track item from the origin of the section. Before I realised this I was calculating the distance from scratch but found the values agrees to within a couple of centimetres.
I suggest that the comment is revised to something like:
/// <summary>Distance of a track item along its containing track section, measured from the origin of the section.</summary>
Regards,
D.
Revision history for this message
| cjakeman (cjakeman) wrote | #1 |
| Changed in or: | |
| status: | New → Fix Committed |
| importance: | Undecided → Low |
| assignee: | nobody → cjakeman (cjakeman) |
| milestone: | none → 1.x |
To post a comment you must log in.
Hi David,
Thanks for this.
I have submitted a Pull Request which changes the <summary> comment as you suggest. That should end up in the Unstable Version shortly and the Testing Version in a week or so.
I found the <summary> at line 905 rather than 784, so perhaps you are using an old version?
If you would like some help in submitting your own changes to Open Rails code, then I would be happy to help.
best wishes,
Chris