Variable 3 on diesels and electrics, variable 2 on electrics computed incorrectly

Bug #1502672 reported by disc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Open Rails
Fix Released
Medium
disc

Bug Description

Variable3 on diesels/electrics should return raw dynamic brake force percentage, but currently friction brake force, and drivetrain losses are also included, which means that with DB max 90% variable3 can be reached (because of -10% drivetrain loss), and also reacts to friction brake force, while shouldn't.

Variable2 on electrics should return raw tractive force percentage, but includes drivetrain losses, and friction brake force.

Revision history for this message
disc (disc86543) wrote :

I've done the fix, will upload soon.

Changed in or:
assignee: nobody → disc (disc86543)
Revision history for this message
disc (disc86543) wrote :

here is the patch

Revision history for this message
Carlo Santucci (carlosanit1) wrote :

First part of disc's fix (diesels excluded) uploaded by me on disc's request in release 3281.

Changed in or:
status: New → In Progress
Revision history for this message
disc (disc86543) wrote :

It seems the diesel will stay as is. The diesellocomotive.cs is so messy that i can't see through it and make the inheritance correctly used.

disc (disc86543)
Changed in or:
status: In Progress → Fix Committed
James Ross (twpol)
Changed in or:
milestone: none → 1.1
importance: Undecided → Medium
James Ross (twpol)
Changed in or:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers