System.ArgumentOutOfRangeException at ORTS.AITrain.UpdateStationState (X3202, Milwaukee RMD East, Milw 01)

[Kevin Knobl]

OR (X3202) crashes during RMD East, Holiday Hiawatha activity. Log file attached.

Also, log file mentions using overheadwire.ace from the OR Addons folder; however I can find no such folder.

[Carlo Santucci (carlosanit1)]

Can you pls. check if this has been solved after release x3225?

[Kevin Knobl (kknobl)]

I am still getting an error at the same point in the same activity. RMD East Activity Milw 10: Transfer Job.

I ran the activity on OR X3243.

Log file is attached.

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Carlo Santucci
Sent: Friday, September 04, 2015 4:33 PM
To: <email address hidden>
Subject: [Bug 1478298] Re: System.ArgumentOutOfRangeException at ORTS.AITrain.UpdateStationState (X3202, Milwaukee RMD East, Milw 01)

Can you pls. check if this has been solved after release x3225?

--
You received this bug notification because you are subscribed to the bug report.
https://bugs.launchpad.net/bugs/1478298

Title:
  System.ArgumentOutOfRangeException at ORTS.AITrain.UpdateStationState
  (X3202, Milwaukee RMD East, Milw 01)

Status in Open Rails:
  Triaged

Bug description:
  OR (X3202) crashes during RMD East, Holiday Hiawatha activity. Log
  file attached.

  Also, log file mentions using overheadwire.ace from the OR Addons
  folder; however I can find no such folder.

To manage notifications about this bug go to:
https://bugs.launchpad.net/or/+bug/1478298/+subscriptions

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

[Carlo Santucci (carlosanit1)]

I see, but pls. note that the log you attached is from activity Milw10_TransferJob, while the former one was from activity Milw01_HolidayHiawatha.

[Kevin Knobl (kknobl)]

My bad.

I will give Milw_01 a shot and let you know.

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Carlo Santucci
Sent: Saturday, September 05, 2015 1:52 PM
To: <email address hidden>
Subject: [Bug 1478298] Re: System.ArgumentOutOfRangeException at ORTS.AITrain.UpdateStationState (X3202, Milwaukee RMD East, Milw 01)

I see, but pls. note that the log you attached is from activity Milw10_TransferJob, while the former one was from activity Milw01_HolidayHiawatha.

--
You received this bug notification because you are subscribed to the bug report.
https://bugs.launchpad.net/bugs/1478298

Title:
  System.ArgumentOutOfRangeException at ORTS.AITrain.UpdateStationState
  (X3202, Milwaukee RMD East, Milw 01)

Status in Open Rails:
  Triaged

Bug description:
  OR (X3202) crashes during RMD East, Holiday Hiawatha activity. Log
  file attached.

  Also, log file mentions using overheadwire.ace from the OR Addons
  folder; however I can find no such folder.

To manage notifications about this bug go to:
https://bugs.launchpad.net/or/+bug/1478298/+subscriptions

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

[Kevin Knobl (kknobl)]

Still had MILW01_Holiday Hiawatha crash.

Not sure if it's the same as the original error, but it occurred around the same spot on the route.

Using OR X3243.

Log file attached.

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Carlo Santucci
Sent: Saturday, September 05, 2015 1:52 PM
To: <email address hidden>
Subject: [Bug 1478298] Re: System.ArgumentOutOfRangeException at ORTS.AITrain.UpdateStationState (X3202, Milwaukee RMD East, Milw 01)

I see, but pls. note that the log you attached is from activity Milw10_TransferJob, while the former one was from activity Milw01_HolidayHiawatha.

--
You received this bug notification because you are subscribed to the bug report.
https://bugs.launchpad.net/bugs/1478298

Title:
  System.ArgumentOutOfRangeException at ORTS.AITrain.UpdateStationState
  (X3202, Milwaukee RMD East, Milw 01)

Status in Open Rails:
  Triaged

Bug description:
  OR (X3202) crashes during RMD East, Holiday Hiawatha activity. Log
  file attached.

  Also, log file mentions using overheadwire.ace from the OR Addons
  folder; however I can find no such folder.

To manage notifications about this bug go to:
https://bugs.launchpad.net/or/+bug/1478298/+subscriptions

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

[Dennis A T (dennisat)]

I am getting the same problem, see attached log. It is being caused by line 2023 in AITrain.cs: " PreviousStop = StationStops[0].CreateCopy(); " This is happening when the train has left its last stop and StationStops is empty. Thus the crash. Line 2023 is redundant since it is duplicated by line 1894: " PreviousStop = thisStation.CreateCopy();" This line correctly records the previous station under all circumstances before line 1933: " bool[] endOfPath = ProcessEndOfPath(presentTime); " is executed. Under some circumstances, this routine can decrement StationStops. If this is the case, "removeStation = false;" is set and at line 2025, there is thus no attempt to remove the Station again but at line 2023, an attempt is incorrectly made to record the Previous stop again. I have fixed the problem by removing line 2023. I have only the one instance of this crash so I cannot guarantee that it fixes the problem under all circumstances.

Dennis

[Carlo Santucci (carlosanit1)]

Thank you very much, Dennis.
I added this line very recently, in x.3214 that introduces player train switching. I have to remember why I did that and if it is really necessary and if it can simply be removed.

[Carlo Santucci (carlosanit1)]

In fact this part must be in sync with the new method CheckStationTask().

[Carlo Santucci (carlosanit1)]

Tentative fix in x.3250.

[Carlo Santucci (carlosanit1)]

At the moment I have preferred to check if there is yet at least a station stop in the list before performing the copy, instead of deleting the line. Kevin and Dennis, it would be nice if you could check x.3250.

[Dennis A T (dennisat)]

I have checked X3250 and it fixes the crash. In fact, your code is exactly what I tried first. When I tracked PreviousStop however, I decided, as I noted previously, that line 2023 was not actually needed. If UpdateStationState() was ever entered when StationStops is empty, it would crash immediately at line 1782 "StationStop thisStation = StationStops[0];"

Dennis

[Dennis A T (dennisat)]

My apologies Carlo, the assignment of PreviousStop is best done at line 2023 as you have modified. More thorough testing has revealed that my solution would mean PreviousStop is incorrect if departure is denied.

Dennis

[Carlo Santucci (carlosanit1)]

Yes, now that you say this it came into mind to me that this was the reason for that. I was quite sure that the insertion of this line had a purpose.

[Kevin Knobl (kknobl)]

Same activity still crashing, same spot.

See attached.

Using OR X3253.

Kevin

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Carlo Santucci
Sent: Wednesday, September 09, 2015 1:00 PM
To: <email address hidden>
Subject: [Bug 1478298] Re: System.ArgumentOutOfRangeException at ORTS.AITrain.UpdateStationState (X3202, Milwaukee RMD East, Milw 01)

Yes, now that you say this it came into mind to me that this was the reason for that. I was quite sure that the insertion of this line had a purpose.

--
You received this bug notification because you are subscribed to the bug report.
https://bugs.launchpad.net/bugs/1478298

Title:
  System.ArgumentOutOfRangeException at ORTS.AITrain.UpdateStationState
  (X3202, Milwaukee RMD East, Milw 01)

Status in Open Rails:
  In Progress

Bug description:
  OR (X3202) crashes during RMD East, Holiday Hiawatha activity. Log
  file attached.

  Also, log file mentions using overheadwire.ace from the OR Addons
  folder; however I can find no such folder.

To manage notifications about this bug go to:
https://bugs.launchpad.net/or/+bug/1478298/+subscriptions

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

[Cédric GNIEWEK (sharpeserana)]

Does the problem still happen with version 1.4?

[Launchpad Janitor (janitor)]

[Expired for Open Rails because there has been no activity for 60 days.]