Defective shape causes hang (X2602, GM&O Springfield Switch, inspect)

[Jeffrey Kraus]

Shape files use index values to refer to other parts of the shape file. If some of these values are out of range Train Simulator will function but display garbled graphics.

If a vertex index is out of range it will show a long line as shown at http://www.trainsim.com/vbts/showthread.php?320561-Corrupt-shape-files

Open Rails instead freezes in a loop but does not crash.

[Peter Gulyas (pzgulyas)]

Could you please provide a download link to the vehicle OR freezes in an infinite loop with?

[Jeffrey Kraus (krausyaoj)]

Download link: https://www.adrive.com/public/secxyj/GMO880B.zip

Fixing this bug will involve changes to the shape file reading code to check the validity of files. In particular, that indexes are within range.

[Peter Gulyas (pzgulyas)]

Thank you for the reference!

I still think writing a full-featured validator for MSTS .s format is not worth the effort. It must have been done by the MSTS developers, when they wrote their GMAX export plugin. This .s shape format now is not our future, it is our past. In the future we would rather implement a more recent and more widely supported format, for which the validator is also available.

And think of it: If the content creator does not care about his model displaying faulty, why would we care about it? At best, we can get around the infinite loop and write a warning line into the log file about e.g. index out of range. But in neither case we would disallow displaying any shape that otherwise don't crash the program.

[James Ross (twpol)]

If you leave Open Rails hung for a minute or two, it should crash itself when it detects that it has hung. That log file would be more useful.

[Cédric GNIEWEK (sharpeserana)]

Does the problem still happen with version 1.4?

[Launchpad Janitor (janitor)]

[Expired for Open Rails because there has been no activity for 60 days.]