X2418 restore after save of geared engine crashes

[Carlo Santucci]

Select any route, select the standard Kiha as player loco and start. Save the game. When restoring the game an exception is generated, because GearBoxController is null in the call of line 228 of MSTSDieselLocomotive.cs.

[BB25187 (bb25187)]

First, the engines with manual gear box do expose the problem as well.
 Second, the issue was introduced with revision #2381/2382 "Rolling stock loading process reorganization" (everything was OK at #2380). I attached another log file to the initial thread (http://www.elvastower.com/forums/index.php?/topic/24874-crash-in-restore-for-version-x2402/#entry158804) to illustrate (I got it with rev #2382 while back tracking the problem, but it is still there at rev #2419).

[Cédric GNIEWEK (sharpeserana)]

I will come back from holidays tomorrow, I will now be able to work on this issue.

[disc (disc86543)]

This happens with electric locomotives too.

[Cédric GNIEWEK (sharpeserana)]

For the moment, I only had problems with geared locomotives.

Can you send a log for your crash, please ?

[disc (disc86543)]

It's not connected to consist, or route, but to activity. Same consit on same route in explore mode, and the resume works. There is no any diesel locomotive in that activity.
This is about that problem:
Warning: System.NullReferenceException: Object reference not set to an instance of an object.
   at ORTS.ControllerFactory.Restore(IController controller, BinaryReader inf) in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\RollingStock\SubSystems\Controllers\ControllerFactory.cs:line 47
   at ORTS.MSTSDieselLocomotive.Restore(BinaryReader inf) in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\RollingStock\MSTSDieselLocomotive.cs:line 228
   at ORTS.Train.RestoreCars(Simulator simulator, BinaryReader inf) in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\Physics\Train.cs:line 776
   at ORTS.Train..ctor(Simulator simulator, BinaryReader inf) in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\Physics\Train.cs:line 501
   at ORTS.Simulator.RestoreTrains(BinaryReader inf) in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\Simulator\Simulator.cs:line 925
   at ORTS.Simulator.Restore(BinaryReader inf, Single initialTileX, Single initialTileZ) in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\Simulator\Simulator.cs:line 331
   at ORTS.Processes.GameStateRunActivity.Resume(UserSettings settings, String[] args) in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\Processes\GameStateRunActivity.cs:line 389
   at ORTS.Processes.GameStateRunActivity.<>c__DisplayClass8.<Load>b__3() in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\Processes\GameStateRunActivity.cs:line 155
   at ORTS.Processes.GameStateRunActivity.Load() in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\Processes\GameStateRunActivity.cs:line 190
   at ORTS.Processes.LoaderProcess.Load() in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\Processes\LoaderProcess.cs:line 122
   at ORTS.Processes.LoaderProcess.DoLoad() in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\Processes\LoaderProcess.cs:line 103
   at ORTS.Processes.LoaderProcess.LoaderThread() in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\Processes\LoaderProcess.cs:line 74
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()

Error: ORTS.Processes.IncompatibleSaveException: Exception of type 'ORTS.Processes.IncompatibleSaveException' was thrown.
   at ORTS.Processes.GameStateRunActivity.Resume(UserSettings settings, String[] args) in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\Processes\GameStateRunActivity.cs:line 410
   at ORTS.Processes.GameStateRunActivity.<>c__D...

[Cédric GNIEWEK (sharpeserana)]

In your log, it is a diesel locomotive that causes the crash. The log shows that it comes from the same line of code as the first log that was sent by Carlo.

I think I will have a fix ready for this evening (in 9 hours more or less). I have to go back to work.

[Cédric GNIEWEK (sharpeserana)]

It should be fixed in revision 2435.