Missing sound triggers for loco power toggle

Bug #1238185 reported by Carlo Santucci
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Open Rails
Fix Released
Low
Carlo Santucci

Bug Description

The welcome new functions added by Matej and allowing to singularly powering locos misses the sound triggers hooks.
Moreover there is an incoherence between power toggling electrics and diesels by the existing commands:
- in electrics raising or lowering pantos with P and Shift-P has effect only on MUed units (seeems reasonable)
- in helper diesels powering on or off with Shift-Y has effect on both MUed and non-MUed helpers.

Attached is a patch that adds sound trigger hooks and that applies to helper diesels the same logic used for electrics.

I kindly ask Matej, Peter or someone other enabled developer to commit the patch.

Tags: physics sounds
Revision history for this message
Carlo Santucci (carlosanit1) wrote :
Changed in or:
assignee: nobody → Matej Pacha (matej-pacha)
James Ross (twpol)
Changed in or:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Peter Gulyas (pzgulyas) wrote :

Patch applied as r1923.

Changed in or:
status: Triaged → Fix Committed
Revision history for this message
Carlo Santucci (carlosanit1) wrote :

Thanks Peter!

James Ross (twpol)
Changed in or:
milestone: none → 1.0
assignee: Matej Pacha (matej-pacha) → Carlo Santucci (carlosanit1)
James Ross (twpol)
Changed in or:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.