signals show wrong animations at German route Pro Train 6 Vogelfluglinie (X.1716)

Bug #1214052 reported by Thomas Pilder
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Open Rails
Expired
Medium
Unassigned

Bug Description

With all activities on that route the semaphore signals show the wrong animations. The lights are correct.
I figured out the reason.

This is part of the original sigcfg.dat (I added two comments):

  SignalDrawStates ( 2
   SignalDrawState ( 0
    "Hp0"
    DrawLights ( 1
     DrawLight ( 0 )
    )
    SemaphorePos ( 1 ) //MSTS shows position 0, OR shows position 1
   )
   SignalDrawState ( 1
    "Hp1"
    DrawLights ( 1
     DrawLight ( 1 )
    )
    SemaphorePos ( 2 ) //MSTS shows position 1, OR shows position 0
   )
  )

MSTS seems to do an internal renumbering if SemaphorePos index doesn't start with zero. OR does not.
I changed the indizes starting with zero and OR shows the correct animations.

I think the behaviour of OR is correct, but it would help very much if OR would be as tolerant as MSTS.

Greetings from Germany

Thomas Pilder

Tags: signals graphs
Revision history for this message
Thomas Pilder (v200) wrote :
Revision history for this message
James Ross (twpol) wrote :

That's very interesting... I wonder if that's also what is going on in bug #1096831 (comment #9 especially).

Changed in or:
status: New → Triaged
importance: Undecided → Medium
tags: added: graphs
removed: semaphore
Revision history for this message
Thomas Pilder (v200) wrote :

Sorry, I did'nt see that bug report before. It seems to be the same issue. Attachment Hanau.jpg (comment #1) shows a similar situation. Several Pro Train routes use the same sigcfg data with frame numbers starting at 1 instead of 0. IMO comment #9 is correct. But it is still unfixed.

Revision history for this message
James Ross (twpol) wrote :

Yeah, that bug did fix the animation for some things but the switch stands are animating backwards (nobody bothered to reply to my question on that in bug 1096831 :( ) in the case of these "odd" values. We'll use this bug to track that oddity.

Revision history for this message
Tim Holliday (tialho) wrote :

Just flagged a similar issue on the UKTS forum and was advised to post here - I'm seeing this issue on a number of German commercial routes (GR and ProTrain), even with the latest OR version x2299

A bit of independent fiddling with sigcfg.dat found that a straight reversal of the values of the SemaphorePos parameter (1 to 2 and vice versa) fixed the issue for OR, as did replacing the value 2 with zero; however, n both cases, the amended sigcfg.dat caused incorrect signal displays in MSTS. To clarify:

Original parameters:

SemaphorePos ( 2 )
SemaphorePos ( 1 ) MSTS correct, OR incorrect

Change to:

SemaphorePos ( 1 )
SemaphorePos ( 2 ) MSTS incorrect, OR correct

Or:

SemaphorePos ( 0 )
SemaphorePos ( 1 ) MSTS incorrect, OR correct

Hope this may shed some light on what is going on!

James Ross (twpol)
summary: signals show wrong animations at German route Pro Train 6 Vogelfluglinie
- ORX1717
+ (X.1716)
Revision history for this message
James Bradley, Jr. (jbrad1974) wrote :

This is exactly the same bug I reported for the Train Order Boards on the Monon route. The signal's lights were displaying correctly, but the semaphore arms were backwards. After reversing the SemaphorePos variables, the order board displays correctly now. It would appear that the SemaphorePos variable is reversed in OR.

Revision history for this message
James Bradley, Jr. (jbrad1974) wrote :
Revision history for this message
James Ross (twpol) wrote :

Tim, what happens if you replace the original:

SemaphorePos ( 2 )
SemaphorePos ( 1 ) MSTS correct, OR incorrect

With:

SemaphorePos ( 1 )
SemaphorePos ( 0 )

Changed in or:
assignee: nobody → James Ross (twpol)
Revision history for this message
Cédric GNIEWEK (sharpeserana) wrote (last edit ):

Does the problem still happen with version 1.4?

Changed in or:
status: Triaged → Incomplete
assignee: James Ross (twpol) → nobody
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for Open Rails because there has been no activity for 60 days.]

Changed in or:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.