Smoke and stem look bright at night

Bug #1177814 reported by BB25187 on 2013-05-08
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Open Rails
Medium
James Ross

Bug Description

With OpenRails, the steam/smoke of steam and diesel engines keeps the same illumination/color at night. When it makes use of a white or grey color, then it looks bright at night. This is not very realistic. Like precipitations, it should become darker.
This can be fixed by using the same shading method as rain drops and snow flakes. SVN patch is attached.

Images before the change:
http://imageshack.us/a/img825/7906/before01.jpg
http://imageshack.us/a/img706/874/before02.jpg
http://imageshack.us/a/img28/4449/before03.jpg
http://imageshack.us/a/img201/4686/before04.jpg

Images after the change:
http://imageshack.us/a/img109/6056/after01r.jpg
http://imageshack.us/a/img832/4066/after02.jpg
http://imageshack.us/a/img197/5479/after03.jpg
http://imageshack.us/a/img600/6602/after04.jpg

BB25187 (bb25187) wrote :
description: updated
description: updated
James Ross (twpol) wrote :

Patch looks good - thanks!

Only tip I have is that "shader.LightVector = Viewer.World.Sky.solarDirection;" can probably go outside the loop, and maybe go as far up as SetState. that can be adjusted by the committer though, no need for a new patch.

tags: added: graphics
removed: shaders smoke steam
BB25187 (bb25187) wrote :

Thanks James.
I agree with your comment. I moved the initialization out of the loop as you suggests. As expected, this still works fine!

James Ross (twpol) on 2013-05-19
Changed in or:
status: New → Triaged
importance: Undecided → Medium
milestone: none → 0.9
James Ross (twpol) on 2013-06-07
Changed in or:
milestone: 0.9 → none
James Ross (twpol) wrote :

Thanks for the patch and sorry for the delay; this is fixed in X.1639.

Changed in or:
status: Triaged → Fix Committed
assignee: nobody → James Ross (twpol)
milestone: none → 0.9
BB25187 (bb25187) wrote :

Thanks James for having integrated the patch!

James Ross (twpol) on 2013-06-20
Changed in or:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers