Wrong Speed Limit in Track Monitor

[Christian Sorenseen]

Speed Limit initially 90 Km/h OK, after passing 2 signals Line Speed is increased to 160 Km/h, shown as 160 kmh left of the green aspect approaching. After passing 2 signals 2 kms apart both showing 160 Km/h the Limit is still shown as 90 Km/h and I am penalized with two red lines in the display.

This problem has shown up in 3 differnt routes, and this time I managed to take a screenshot.

If You want a logfile, I will do one for You, but this error is not locked to just one route.

Thank You for Your great work. :)

Keep up the spirit. :)

ChrisD

[r.roeterdink (r-roeterdink)]

The speedlimit of 90 kmh is correct, it is set by a speedpost and overrules the speed as set by signals.
I assume the signals have a speed defined in the definition of the signal, but this should not be displayed in the trackmonitor if it is overruled by a speedlimit set by a speedpost.
I will look into this.

[Christian Sorenseen (box1-5)]

If it is the speedpost, (the sign beside the track) that sets the limit, I can tell You that I passed 3 signs showing 160 Km/h.

Yesterday i drove a long freighter out of Revelstoke in the Rogers Pass Route from Marple Leaf Tracks. Here the limit changed when the train had completely passed the sign showing a higher speed.

The errors are all on Pro Train Routes using the German ICE trainsets.

I am reluctant to believe that a company that have made 40+ German routes for MSTS and practically every train that runs on German tracks, could have forgotten to mark the end of the train correctly.

I will now make a clean install of MSTS and install only one Pro Train Route, and if I still get this error, I am willing to donate this Route Package to You to check out. Title is Train Sim Pro Brandenburg - Frankfurt/Oder.

I will report back in a couple of Hours.

Once again, thank You for a magnificent piece of software. :)

ChrisD

[Christian Sorenseen (box1-5)]

Checked.

Clean MSTS Install plus:

Pro Train 18 (Ausbaustrecke Hamburg - Berlin)

Explore Route.

Berlin-Tief to Hamburg HBF, Trainset ICE

Speed limit out of Berlin HBF 90 Km/h. Up to 160 Km/h, no change in limit. Passing several speed signs stating 160 Km/h.

This time I use the ICE built-in the PT18 package, no change, so I am pretty sure it is not the train missing something.

Want to try it out Yourself.

I am willing to donate a copy of this package to You to try out. No cheating, I will open an extra customer account by the shop where I bought the pack, Buy one extra copy and provide You the log-in name and password to the recipt and download link.

Send me a PM or an e-mail to <email address hidden>

Yours

ChrisD

[r.roeterdink (r-roeterdink)]

Thanks for your offer - but no need, I've got several ProTrain routes myself.
Another question : did you run in explorer mode, or does the problem also occur when you run a normal activity?
Speedpost processing in explorer mode is different as from normal activity mode.

[Christian Sorenseen (box1-5)]

These sessions were all in Explore Route.

I will try one of the activities to see if the behavior is consistent.

ChrisD

-----Oprindelig meddelelse-----
Fra: <email address hidden> [mailto:<email address hidden>] På vegne af
r.roeterdink
Sendt: 20 March 2013 10:20
Til: <email address hidden>
Emne: [Bug 1157182] Re: Wrong Speed Limit in Track Monitor

Thanks for your offer - but no need, I've got several ProTrain routes
myself.
Another question : did you run in explorer mode, or does the problem
also occur when you run a normal activity?
Speedpost processing in explorer mode is different as from normal
activity mode.

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1157182

Title:
  Wrong Speed Limit in Track Monitor

Status in Open Rails Tracker:
  Confirmed

Bug description:
  Speed Limit initially 90 Km/h OK, after passing 2 signals Line Speed
  is increased to 160 Km/h, shown as 160 kmh left of the green aspect
  approaching. After passing 2 signals 2 kms apart both showing 160 Km/h
  the Limit is still shown as 90 Km/h and I am penalized with two red
  lines in the display.

  This problem has shown up in 3 differnt routes, and this time I
  managed to take a screenshot.

  If You want a logfile, I will do one for You, but this error is not
  locked to just one route.

  Thank You for Your great work. :)

  Keep up the spirit. :)

  ChrisD

To manage notifications about this bug go to:
https://bugs.launchpad.net/or/+bug/1157182/+subscriptions

[Christian Sorenseen (box1-5)]

I can not drive out of Berlin Tief in the two sessions offered in the pack, the train crashes when I raise the Pantograph.

However, I managed to run a session where I drive a Regional train from Hagenov Land towards Hamburg.

Initial speed out of the station is 60, raised to 230 by trackside signs, but limit still stays low.

Hope this helps.

ChrisD

[Christian Sorenseen (box1-5)]

Further Info.

The first two signals show 60 Km/h in the Track Monitor. The following green signals shown when the speed is raised to 230 Km/h has no speed written in the Track Monitor.

ChrisD

[r.roeterdink (r-roeterdink)]

Attached is a special version which creates additional output on route and train details.
To use this :
- go to the Open Rails directory, subdirectory trunk\Program
- rename existing RunActivity.exe file
- unpack attached zip-file and store RunActivity.exe in the Program directory
- ensure you have a directory named C:\temp : the additional output files will be generated in that directory
- run an activity which has this problem - but with the player train only (no AI trains, please)
  please do not run in explorer mode, as the additional info is only generated when running an activity
- stop the activity when the train is well clear of the first signal where you expected the higher speed limit.
   if you can't stop the train before the next signal because of short distance between signal, then please inform me how many 'wrong' signals you passed
- collect all generated files from C:\temp in a zip-file
- if you have to run the activity more than once, please clear all files from C:\temp before running again (not all files are cleared or removed by the program)

Thanks for your help.

   Rob Roeterdink

[Christian Sorenseen (box1-5)]

Hi Rob.

Sorry for the delay, I was out all day Yesterday.

Run1. Out of Hagenov Land without other trains in sight. Error verified. Rem: I noticed that the debug version You provided flag en error when starting, so just to make sure I chose another longer run.

Start Brandenburg, stopped after Havel.

All the way from Brandenburg to Havel the speed is 160, Through Havel it is 150. After Havel the limit is raised again, but this time the error surfaced. End of train way past the 160 sign without change in limit.

Run2.

I met one other train halfway to Havel, however.

I have to go out this afternoon, but when I come back I will try to find more runs, hopefully without interfering AI trains.

ChrisD

[Christian Sorenseen (box1-5)]

The other logfile.

[r.roeterdink (r-roeterdink)]

Hello Chris,

thanks for the files - no need to do anymore, can work from this set.
However, I do need to have a look at the signal definition - can you please attach the sigcfg.dat file?

Thanks,
    Rob Roeterdink

[Christian Sorenseen (box1-5)]

I include both sigcfg.dat files in the archive.

Thank You for Your effort. :) I hope You can pinpoint the problem.

Happy Easter Holiday to the whole OR Development Team.

ChrisD

[r.roeterdink (r-roeterdink)]

Thanks for the files.
I am getting closer to this.
From the sigcfg.dat files, I needed the information that the signal which raises the speed to 160 kmh does indeed set this limit if cleared.
It does, but the train never gets this information.
There are now two possible causes :
1) when the signal is processed and the signal database is set up, the speed limit is not processed correctly, and therefor not linked to the signal.
2) when the train passes the signal, the speed limit is ignored.

I will work on this, it might be I still need some further print-outs.

Thanks for your help.
And you are a week early for Easter ;) !

[r.roeterdink (r-roeterdink)]

Hello Chris,

Could you please run the attached patch version?
I have made a change which did affect this issue - if there were no speedposts at all, the maximum speed was set to the speed limit of the first signal - signals setting higher limits later on were ignored.
This explains part of the problem but not all, so I have also added further print statements.

Same procedure as before.

Thanks,

   Rob Roeterdink

[Christian Sorenseen (box1-5)]

Hello Rob.

I have done the first run out of Hagenov Land.

This time the Track Monitor speed limit shows 230 Km/h all the way from start until I stop the train.

The In-CAB display still changes btw. 60 and 230 Km/h.

If You want me to make the other longer run out of Brandenburg, just let me know.

good Luck, and Thank You again.

ChrisD

[r.roeterdink (r-roeterdink)]

Hello Chris,

thanks - that was clearly not the correct patch, but the print-outs did provide the clue.

It comes done to a 'rounding' error of the speed values.
The overall route speed is converted to 63.8871 m/s, the signal speed to 63.8888 m/s.
Because the signal speed is higher than the max. allowed speed, it is ignored.
I've now made a change that, in such situations, sets the speed to the maximum allowed speed.

Could you please try this again?

Thanks.

[Christian Sorenseen (box1-5)]

Spot on Rob. :)

This time it works.

I tried both runs and the speed limit works just fine.

I send the logfile for Hagenov Land towards Hamburg as before, but also the run from Brandenburg towards Berlin functions spot on.

One minor issue that purists may notice is, that when the train initially stands at the platform, speed limit is set at max line speed. However the correct speed of 60 Km/h is set the instant the engine passes the first signal at the end of the platform.
As I see it, there is no way the program could predict that, unless the activity actually started before entering the station. Then the train would physically pass a signal/speed sign that dictates 60 Km/h at the platform. (This initial speed limit should be written into the activity, If I had something to say.)

In my opinion, the change You have made to the code, cures the bug that I reported.

Once again, thank You for Your dedicated effort.

Need any more beta-testing? Just give the word, and I will be glad to help if I can.

All the best to You and Your fellow developers and their Families.

You are doing a magnificent Job, keep up the good work spirit.

ChrisD

[Christian Sorenseen (box1-5)]

Further info.

In Explore Mode the problem seems to be persistent, speed limit shifts down when the engine passes the sign, but not back up again as the end of the train passes the sign with the increased speed limit.

I will try to run an Explore Route session with the same consist as in the activity, once I figure out how.

Running with different consists, presents the possibility that end of train marker is not in place on the Explore Route Consist.

I will be back with more info.

ChrisD

[r.roeterdink (r-roeterdink)]

Thanks - I will commit the change later today.

Regarding the speed limit when activity starts : because the route has no speedlimit signs anywhere, and the train has not yet passed any signals, it is not possible to determine the speed limit which applies to the location where the train starts.

Regarding the problem in explorer mode : I will have a look at that. Signal and speedlimit control in Explorer mode is largely a separate process.

Regards,

   Rob Roeterdink

[Christian Sorenseen (box1-5)]

Hi Rob.

Just found the consist that was used in the activity out of Hagenov Land.

Running in Explorer Mode, speed limit shifts down, but still not up, so it seems it has nothing to do with missing end of train marker.

I notice that explorer mode is a separate process, so I will stick to activities for now :)

Practical info: this bug-finding version of RunActivity, has severely degraded display performance. Display stutters every 1 to 2 seconds. Just to keep in mind when extending the code in the future, this is not a good place to introduce further disk I/O activity.

Looking forward t the patched Game. :)

ChrisD

[r.roeterdink (r-roeterdink)]

Chris,

the 'stutter' in the test-version is because of the large amount of text written to the additional output files.
That process is not active in the normal version. But given the complexity of the signalling process, it is the only way I can gather all the required information.

Regards,

  Rob Roeterdink

[r.roeterdink (r-roeterdink)]

Fix committed for Normal mode (X 1506).
Report remains open as problems still persists in Explorer mode.

[Christian Sorenseen (box1-5)]

Further info.

Freeware route Hannover - Berlin ver. 2.1 available at bahn-simulation.de has some of the best scenery I have ever seen in OR, but more important:

The speed limit in Track Monitor works flawlessly, both in Activities and in Explorer Mode.

Speed limit shift nicely both up and down at the right moments.

Obviously the team here do something different than the Folks at Blue Sky, something that works with OR :)

Finding the difference may help pinpoint the spot in Your software.

Want me to take another ride with debug-code on? Just let me know and I will be glad to help.

ChrisD

[Christian Sorenseen (box1-5)]

Errata:

Typo, sorry, line should read:

Finding the difference may help pinpoint the right spot in Your software.

ChrisD

[r.roeterdink (r-roeterdink)]

It's likely that route uses speedposts to set speedlimits, rather than using signals only.
That is easy to check : just check for the word 'speedpost' in the tdb-file.

Regards,

   Rob Roeterdink

[Denis Verheyden (msts-2)]

For me, this bug is still not fixed. In explore mode, speeds set by (invisible) signals, as in ProTrain routes, are still ignored. For example, the speed limit at the start is 80 km/h. Then a signal which sets the maximum speed to 160 km/h follows, but the maximum allowed speed stays at 80 km/h.

In activities, signals and speed limits do function correctly. Yet, explore mode is just an activity where the path is not fixed in advance (or where the path can take infinite ways or exits), but other than that it should function like when running an activity !

[Cédric GNIEWEK (sharpeserana)]

Does the problem still happen with version 1.4?

[Launchpad Janitor (janitor)]

[Expired for Open Rails because there has been no activity for 60 days.]