shadowing glitch

Bug #1098600 reported by disc
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Open Rails
Fix Released
Medium
James Ross

Bug Description

I've seeing a shadowing problem since the dynamic shadows are implemented. I can't really explain it with words, so i've attached a video instead.

Tags: graphics
Revision history for this message
disc (disc86543) wrote :
Revision history for this message
James Ross (twpol) wrote :

Does it still happen with an experimental build of V1371 or later?

Revision history for this message
disc (disc86543) wrote :

Yes, this video made with the latest, V1388

Revision history for this message
Wayne Campbell (wayneinbc) wrote :

Just as a possible clue here ... I have noticed this sort of behaviour when a scene contains objects made up of 'large' mesh triangles. If the mesh triangles in a scenery object exceed about 200 meters in length, then the shadows are effected as shown in the video.

James Ross (twpol)
tags: added: shadows
removed: glitch shadowing
Revision history for this message
cjakeman (cjakeman) wrote :

Hi Kerko,

Very convincing video. Can you tell us where to download this route and where the station building is? Is the route available for free?

Thanks,

Chris

Revision history for this message
disc (disc86543) wrote :

It's free, Xtracks needed for it:
https://docs.google.com/uc?id=0BwJFITblw5mXbE96QWFlbWlLNE0&export=download

This bug at Budapest-Nyugati or Nyugati
Probably because the whole station building is modeled in one piece, so it's very big.

Revision history for this message
cjakeman (cjakeman) wrote :

Hi Kerko,

Thanks for packaging up the XTracks which the route needs. But I still don't have the name of the route or from where to download it. Am I missing something?

Best wishes,

Chris

Revision history for this message
Peter Gulyas (pzgulyas) wrote :

(Just a note from an outsider: The zip in comment #6 contains the route, not the XTracks. It's name is "Alföld", it is the largest free route from Hungary. An alternative download link in case google docs isn't preferred: http://www.simtreni.com/download/index.php?subcat=7 . But in this case it must be downloaded in more parts.)

James Ross (twpol)
tags: added: graphics
Revision history for this message
Peter Gulyas (pzgulyas) wrote :

I can reproduce this bug only with ShadowAllShapes turned on in registry.

Revision history for this message
Peter Gulyas (pzgulyas) wrote :

I could reproduce this bug in r1477 on standard route with standard rolling stock as well.

1. Create new registry key of type DWORD and set its value to 1: HKEY_CURRENT_USER\Software\OpenRails\ORTS\ShadowAllShapes

2. Start OR, and select route Northeast Corridor, activity Summer Express

3. When game started, go to camera 3

4. Zoom out with PageDown key till it is possible.

Now the weird shadow gets visible. You can also try rotating around to see it moving.

Changed in or:
status: New → Confirmed
cjakeman (cjakeman)
Changed in or:
status: Confirmed → Triaged
Revision history for this message
disc (disc86543) wrote :

Actually this happens every time at everywhere, even without shadowallshapes. It's more noticeable at morning and evenings when the shadows are longer.

James Ross (twpol)
Changed in or:
importance: Undecided → Medium
Changed in or:
milestone: none → 0.9
Revision history for this message
James Ross (twpol) wrote :

I cannot reproduce using the steps in command #10 but I have seen this occasionally myself so I'll have a look.

Changed in or:
assignee: nobody → James Ross (twpol)
status: Triaged → In Progress
Revision history for this message
James Ross (twpol) wrote :

Fixed in V1508.

Changed in or:
status: In Progress → Fix Committed
Revision history for this message
Wayne Campbell (wayneinbc) wrote :

May be related to Bug 1160216

Revision history for this message
disc (disc86543) wrote :

now a similar bug appeared again. I use V 1517

See the video

Revision history for this message
disc (disc86543) wrote :

Actually, this is worse than before :(

Revision history for this message
disc (disc86543) wrote :

Since the distant mountain update, i'm seeing long flickering shadow stripes too.

Revision history for this message
James Ross (twpol) wrote : RE: [Bug 1098600] Re: shadowing glitch

Did you experience better/fixed shadowing after the fix was committed and before the Distant Mountains (DM) were added? If you're ONLY seeing the issue with DM enabled in the options, please file a new bug on that. If you're seeing the same issue with and without DM enabled, I'll investigate more here. The flickering stripes should also go in to the new bug, as it's dependent on that experimental feature. Thanks!

Revision history for this message
disc (disc86543) wrote :

I've made the video one day before the first release of DM, so which is in the video, that isn't in connection with DM. After the fix, the angle dependent disappearing shadows gone, but few releases later(before the DM) i saw those that are in the video.

 But the stripes are probably caused by DM.

Revision history for this message
disc (disc86543) wrote :

I've just reviewed the old video and compared with the current problem and as i see, it's the same problem.

James Ross (twpol)
Changed in or:
status: Fix Committed → In Progress
Revision history for this message
disc (disc86543) wrote :

another video about the "camera following" shadow and the "growing tree" shadows, maybe it can help to find out the problem.

Revision history for this message
James Ross (twpol) wrote :

Sorry about the delay with this bug, but I don't think the video in comment #21 is actually caused by the change here. There are other issues that are caused by it, however (some of the issues in the video in comment #15, for example).

Revision history for this message
disc (disc86543) wrote :

these shadow are also visible on default tokyo-hakone route, selecting shinjuku - machida path, at spring, time set to 12:00. It seems the problem occurs when of the shadows of big buildings, with big faces. But doesn't with smaller houses.

James Ross (twpol)
tags: removed: shadows
James Ross (twpol)
Changed in or:
status: In Progress → Fix Committed
Revision history for this message
James Ross (twpol) wrote :

The original issue here has been fixed in V1597. The shadowing issue on water seen in the 3rd video is a separate issue and should be filed as a new bug.

Revision history for this message
disc (disc86543) wrote :

It's "fixed" indeed... because now the shadows are now completely disappeared :D

Revision history for this message
disc (disc86543) wrote :

oops no, arent disappeared, but depending on time of day, the shadows can be very faint, barely visible. This happens when the time is closing to noon.

Revision history for this message
James Ross (twpol) wrote :

They look fine to me, but if they have got fainter it's directly as a result of the required change to fix the platform being in shadow in this bug. You can't have everything, unfortunately.

Revision history for this message
disc (disc86543) wrote :

It seems that the shadows have fixed color shouldn't be work as substractive material does? And why the color of shadows are depending on time? Actually in reality, the highest contrast between lit and shadowed surfaces are at noon. But now in OR the opposite happens.

Revision history for this message
James Ross (twpol) wrote :

You have absolutely no idea how shadows are implemented. They are very sensitive to any changes and it is impossible to satisfy everyone's desires for them at once. Maybe I'll have another free weekend to dedicate to them (I've spent *many days* working on this issue) some time but until then, this bug is fixed.

Revision history for this message
James Ross (twpol) wrote :

BTW, you can mostly 'fix' the lighter shadows by turning off ShadowMapBlur.

Revision history for this message
James Ross (twpol) wrote :

Okay, turned out to be easier to fix the faint shadows, so they should be sorted in X.1600.

James Ross (twpol)
Changed in or:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.