Insifficient test coverage for oqgraph

Bug #645830 reported by Philip Stoev on 2010-09-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MariaDB
Won't Fix
High
Arjen Lentz
OQGRAPH
High
Open Query core

Bug Description

It appears that the test coverage provided by the oqgraph MTR suite is not sufficient. Since it was not possible to obtain gcov numbers, the observations below are based on a visual examination of the test suite.

It appears that the following is missing from the test suite:

- a complete list of the SELECT statements that are accepted by the engine, as described in
the manual, including those with latch=0 or latch = NULL;
- DML and SELECT statements with weight != 0
- queries that will be rejected by the storage engine, including invalid DDL/ALTER, DML that modifies non-modifiable columns, CREATE TABLE with an invalid layout, etc.
- an enumeration of the DML/DDL/ALTER statements that are accepted by the engine, so that all the engine capabilities the handler advertises and all the API calls are exercised, including ALTER ENGINE=, INSERT ... SELECT, CREATE .. SELECT etc.
- verification of each statement after it is executed, e.g. a SELECT must be done after TRUNCATE for a proper test for truncation; an I_S query and CREATE, etc. must be performed after TRUNCATE to test that the table is truly gone, etc.;
- a dataset that is sized appropriately for MTR execution (10K nodes?). Either in the form of INSERT statements or a stored procedure, plus some SELECT queries on top of that dataset;
- joins and other cross-engine operations;

Changed in maria:
milestone: none → 5.2
Philip Stoev (pstoev-askmonty) wrote :

I am attaching the coverage files for oqgraph. Lines marked with #### are not covered.

Changed in maria:
status: New → Confirmed
Changed in oqgraph:
status: New → Confirmed
assignee: nobody → Open Query core (openquery-core)
Changed in maria:
assignee: nobody → Arjen Lentz (arjen-lentz)
Changed in oqgraph:
importance: Undecided → High
Changed in maria:
importance: Undecided → High
Arjen Lentz (arjen-lentz) wrote :

Created two simple data generators:
 - examples/randoms/randtree which can create a simple unidirectional tree structure (like a menu tree)
 - examples/randoms/randsocial can create a social network with friends/weight and fans
both can be specific at arbitrary size, with variable # of friends and fans, and random weight within a range.
This should enable more stringent testing of some aspects.

(present in oqgraph/trunk)

Kristian Nielsen (knielsen) wrote :

It's been >1 year with no activity from upstream. There seems little point in keeping this open for mariadb - there are no plans from mariadb project to take over maintenance of OQGraph.

Changed in maria:
status: Confirmed → Won't Fix
Andrew McDonnell (andymc73) wrote :

This is mostly done for Oqgraph v3 now, including multiple backing stores now in bleeding edge.

I'll close it out after cross-checking if any still of the above needed

Changed in oqgraph:
status: Confirmed → In Progress
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers