Activity log for bug #1227960

Date Who What changed Old value New value Message
2013-09-20 02:55:25 Michele Simionato bug added bug
2013-09-20 02:57:05 Michele Simionato oq-nrmllib: status New In Progress
2013-09-20 02:57:09 Michele Simionato oq-nrmllib: importance Undecided High
2013-09-20 02:57:13 Michele Simionato oq-nrmllib: assignee Michele Simionato (michele-simionato)
2013-09-20 02:58:43 Michele Simionato description In the tests of nrmllib we compare for equality two XML files with the function assert_xml_equal. Two files with the same attributes in different order should be considered equal. The current implementation checks the equality by using etree.tostring, which reorders the attribute. However such feature has been removed in new versions of lxml (now the original order of the attributes is preserved) so assert_xml_equal is no more suitable for its intended purpose. The solution is to use nrmllib.writers.tostring which does the right thing. In the tests of nrmllib we compare for equality two XML files with the function assert_xml_equal. Two files with the same attributes in different order should be considered equal. The current implementation checks the equality by using etree.tostring, which reorders the attributes. However such feature has been removed in new versions of lxml (now the original order of the attributes is preserved) so assert_xml_equal is no more suitable for its intended purpose. The solution is to use nrmllib.writers.tostring which does the right thing.
2013-09-23 09:42:51 Michele Simionato oq-nrmllib: status In Progress Fix Committed