The init script does not handle the script-security parameter correctly when there are multiple configuration files

[Simon Déziel]

When there are 2 or more VPN configuration files and one of them does not use the script-security parameter, the subsequent (alphabetic order) openvpn process will be called with "--script-security 2" no matter what is the value of the script-security parameter in the configuration file. This behaviour only occurs when the init script processes many VPN configuration files in one call (on startup/restart).

Example of the problem :

# grep script-security patrick.conf zzz.conf
zzz.conf:script-security 1

# /etc/init.d/openvpn restart

# ps aux| grep openvpn
openvpn 5705 0.4 0.0 37040 2812 ? Ss 12:27 0:00 /usr/sbin/openvpn --writepid /var/run/openvpn.patrick.pid --daemon ovpn-patrick --cd /etc/openvpn --config /etc/openvpn/patrick.conf --script-security 2
openvpn 5722 0.1 0.0 30968 2996 ? Ss 12:27 0:00 /usr/sbin/openvpn --writepid /var/run/openvpn.zzz.pid --daemon ovpn-zzz --cd /etc/openvpn --config /etc/openvpn/zzz.conf --script-security 2

The process for the "zzz.conf" VPN should have script-security 1 as the configuration file says but it's not the case.

# lsb_release -rd
Description: Ubuntu 11.04
Release: 11.04

# apt-cache policy openvpn
openvpn:
  Installed: 2.1.3-2ubuntu3
  Candidate: 2.1.3-2ubuntu3
  Version table:
 *** 2.1.3-2ubuntu3 0
        500 http://ca.archive.ubuntu.com/ubuntu/ natty/main amd64 Packages
        100 /var/lib/dpkg/status

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: openvpn 2.1.3-2ubuntu3
ProcVersionSignature: Ubuntu 2.6.38-11.47-generic 2.6.38.8
Uname: Linux 2.6.38-11-generic x86_64
Architecture: amd64
Date: Thu Jul 21 11:31:48 2011
ProcEnviron:
 LANGUAGE=en_US:en
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: openvpn
UpgradeStatus: No upgrade log present (probably fresh install)

[Simon Déziel (sdeziel)]

Here is a patch that make sure the script-security parameter is handle properly for each VPN configuration files.

[Simon Déziel (sdeziel)]

I failed to attach the file in my previous comment.