[7.0] Incorrect behaviour for account.invoice.line migration (note & name)

[Sylvain LE GAL (GRAP)]

Hi,

I think that there is a little bug in account module. In the merging of 'name' and 'note' field in account.invoice.line model.

Reproduce the bug.

6.1 :
row #1 : {name : 'my name' ; note : 'my note'}
row #2 : {name : 'my name' ; note : None}

Expected datas after migration in 7.0 :
row #1 : {name : 'my name' + '\n' + 'my note'}
row #2 : {name : 'my name'}

Observed datas :
row #1 : {name : 'my name' + '\n' + 'my note'}
row #2 : {name : None}

Observed log :
WARNING : Table 'account_invoice_line': unable to set a NOT NULL constraint on column 'name' !

[Stefan Rijnhart (Opener) (stefan-opener)]

Thank you for fixing this!

If someone got caught by this, they can fix it on an already migrated database with:

    update account_invoice_line set name = openupgrade_legacy_7_0_name where name is NULL and openupgrade_legacy_7_0_name is not NULL;