vmware: vmdk driver should ignore datastores in maintenance mode

[Vipin Balachandran]

The vmdk driver ignores the maintenanceMode property of a datastore and considers it as a potential candidate for volume creation. Rather, it should ignore datastores in maintenance mode for volume creation.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/80559

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/80559
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=36b5782dea6d0e627c65c73dbfee39d55dbee318
Submitter: Jenkins
Branch: master

commit 36b5782dea6d0e627c65c73dbfee39d55dbee318
Author: Vipin Balachandran <email address hidden>
Date: Fri Mar 14 17:50:27 2014 +0530

    vmware:Ignore inaccessible/inMaintenance datastore

    The vmdk driver uses the number of hosts connected to a datastore as one
    of the criteria for selecting a datastore for volume creation. It might
    incorrectly consider a host to which the datastore is inaccessible while
    computing the number of connected hosts. This is because, the driver
    sometimes uses the aggregated accessible status of a datastore while
    determining its accessibility to a host. Also, the driver is ignoring
    the maintenance status of the datastore and might create a volume in a
    datastore which is entering maintenance or already in maintenance. This
    change fixes these issues in datastore filtering.

    Change-Id: Ibd5c1865d42638a735fd588e9c10e8f714c9c030
    Closes-Bug: #1291346
    Closes-Bug: #1291291