Ensure NVP plugin does not applies SNAT internal traffic

[Salvatore Orlando]

In the NVP plugin, the external gateway creates a default SNAT rule which causes all traffic to be SNATted.
We should ensure that appropriate measures are taken for not SNATting traffic whose destination is instead local.

[dan wendlandt (danwent)]

this is more of a mini-feature, so we should be pushing such things to h1

[dan wendlandt (danwent)]

Salvatore and I chatted about this. I was confusing this issue with a similar one which involved API changes, which we clearly need to bump to H. This bug is a more critical change, as without it, metadata will not work properly if you have an uplink.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23055

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23055
Committed: http://github.com/openstack/quantum/commit/ffad9bf71fd2076f8259d0a7b0527e4ce98c4100
Submitter: Jenkins
Branch: master

commit ffad9bf71fd2076f8259d0a7b0527e4ce98c4100
Author: Salvatore Orlando <email address hidden>
Date: Wed Feb 27 02:28:25 2013 +0100

    NVP Router: Do no perfom SNAT on E-W traffic

    Bug 1130053

    This patch ensures 'No Snat' rules are enforced in order to avoid source
    natting on east-west traffic.

    Change-Id: I967e72e7b6bc8e2763c0fbdf6deeafb43ff27f54