nova.compute.manager has unreachable path

Reported by Nachi Ueno(Instance3) on 2011-11-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Low
Mark McLoughlin
OpenStack Quality Assurance
New
Undecided
Unassigned

Bug Description

nova.compute.manager has unreachable path

https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L306
if not ((bdm['snapshot_id'] is None) or
          (bdm['volume_id'] is not None)):

is equivalent to this:
  if ((bdm['snapshot_id'] is not None) and
      (bdm['volume_id'] is None)):

bdm['volume_id'] is always set L304 if bdm['snapshot_id'] is not None and bdm['volume_id'] is None
https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L304

description: updated
Thierry Carrez (ttx) on 2011-11-25
Changed in nova:
assignee: nobody → Mark McLoughlin (markmc)
importance: Undecided → Low
status: New → In Progress
Mark McLoughlin (markmc) on 2012-01-13
Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-01-25
Changed in nova:
milestone: none → essex-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in nova:
milestone: essex-3 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers