filepath should not be splited by '/'

Reported by Nachi Ueno on 2011-11-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Low
Russell Bryant
OpenStack Quality Assurance
Fix Released
Undecided
Unassigned

Bug Description

inject_data split filepath by '/' which is OS dependent.
os.path.basename() should be used instead.

https://github.com/openstack/nova/blob/master/nova/virt/disk.py#L125

Thierry Carrez (ttx) on 2011-11-08
Changed in nova:
importance: Undecided → Low
status: New → Confirmed

Fix proposed to branch: master
Review: https://review.openstack.org/3591

Changed in nova:
assignee: nobody → Russell Bryant (russellb)
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/3591
Committed: http://github.com/openstack/nova/commit/541f747f055d4a794e8dc50ea78ee6d10913ff26
Submitter: Jenkins
Branch: master

commit 541f747f055d4a794e8dc50ea78ee6d10913ff26
Author: Russell Bryant <email address hidden>
Date: Tue Jan 31 15:25:33 2012 -0500

    Use os.path.basename() instead of string splitting.

    Fixes bug 886268.

    Change-Id: I16e05f4ead55c75f29217072d106421fdc7de201

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → essex-4
Thierry Carrez (ttx) on 2012-02-29
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in nova:
milestone: essex-4 → 2012.1
Nachi Ueno (nati-ueno) on 2013-09-25
Changed in openstack-qa:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers