nova.compute.manager calls methods in nova.volume.manager directly

Bug #872445 reported by Nachi Ueno
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Vish Ishaya
OpenStack Quality Assurance
Fix Released
Medium
Unassigned

Bug Description

nova.compute.manager calls methods in nova.volume.manager directly.
This must be via api module.

146: self.volume_manager = utils.import_object(FLAGS.volume_manager)
1230: dev_path = self.volume_manager.setup_compute_volume(context, volume_id)
1241: dev_path = self.volume_manager.setup_compute_volume(context,
1267: self.volume_manager.remove_compute_volume(context,
1289: self.volume_manager.remove_compute_volume(context, volume_id)
1306: self.volume_manager.remove_compute_volume(context, volume_id)
1401: self.volume_manager.setup_compute_volume(context, v['id'])
1511: self.volume_manager.remove_compute_volume(ctxt, vol['id'])

Nachi Ueno (nati-ueno)
Changed in openstack-qa:
milestone: none → essex-1
Revision history for this message
Nirmal Ranganathan (rnirmal) wrote :

I think this just got merged in by Vishy in one of his volume cleanup branches

Revision history for this message
Nachi Ueno (nati-ueno) wrote : Re: [Bug 872445] Re: nova.compute.manager calls methods in nova.volume.manager directly

>Nirmal Ranganathan
Thanks
I confirmed it is merged to Essex branch.
But I think it is also needed for Diablo Stable Branch.

https://github.com/openstack/nova/blob/2011.3/nova/compute/manager.py

Revision history for this message
Nirmal Ranganathan (rnirmal) wrote :

Ok cool.. yeah not sure what all was going to get backported to Diablo.

On Wed, Oct 12, 2011 at 3:09 PM, Nachi Ueno <email address hidden>wrote:

> >Nirmal Ranganathan
> Thanks
> I confirmed it is merged to Essex branch.
> But I think it is also needed for Diablo Stable Branch.
>
> https://github.com/openstack/nova/blob/2011.3/nova/compute/manager.py
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/872445
>
> Title:
> nova.compute.manager calls methods in nova.volume.manager directly
>
> Status in OpenStack Compute (Nova):
> New
> Status in OpenStack QA:
> New
>
> Bug description:
> nova.compute.manager calls methods in nova.volume.manager directly.
> This must be via api module.
>
> 146: self.volume_manager =
> utils.import_object(FLAGS.volume_manager)
> 1230: dev_path = self.volume_manager.setup_compute_volume(context,
> volume_id)
> 1241: dev_path = self.volume_manager.setup_compute_volume(context,
> 1267: self.volume_manager.remove_compute_volume(context,
> 1289: self.volume_manager.remove_compute_volume(context, volume_id)
> 1306: self.volume_manager.remove_compute_volume(context, volume_id)
> 1401: self.volume_manager.setup_compute_volume(context,
> v['id'])
> 1511: self.volume_manager.remove_compute_volume(ctxt,
> vol['id'])
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/nova/+bug/872445/+subscriptions
>

Thierry Carrez (ttx)
Changed in nova:
status: New → Fix Committed
Nachi Ueno (nati-ueno)
Changed in openstack-qa:
status: New → In Progress
assignee: nobody → Nachi Ueno (nati-ueno)
importance: Undecided → Low
importance: Low → Medium
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Nachi Ueno (nati-ueno)
Changed in openstack-qa:
assignee: Nachi Ueno (nati-ueno) → nobody
tags: added: diablo-backport
Mark McLoughlin (markmc)
Changed in nova:
assignee: nobody → Vish Ishaya (vishvananda)
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-1 → 2012.1
Nachi Ueno (nati-ueno)
Changed in openstack-qa:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.