No documentation about token backends

Bug #986980 reported by Rafael Durán Castañeda
30
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Dolph Mathews
openstack-manuals
Fix Released
High
Unassigned

Bug Description

Documentation lacks of information about token backends: backends available, options, memcached configuration for memcached backend,...

Revision history for this message
Dolph Mathews (dolph) wrote :

Definitely a weak point in the docs, given that we default to KVS.

Changed in keystone:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Anne Gentle (annegentle) wrote :

Dolph, do you intend to document both places? Seems like openstack-manuals is where that type of info belongs. You can move it over if you want.

Changed in openstack-manuals:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Dolph Mathews (dolph) wrote :

Definitely makes more sense in openstack-manuals than in keystone's dev docs-- although there's a LOT of things in the dev docs that belong in openstack-manuals :(

Revision history for this message
Lorin Hochstein (lorinh) wrote :
Revision history for this message
Lorin Hochstein (lorinh) wrote :

Note that people have been having with their database filling up with tokens, which results in poor MySQL performance:

http://lists.openstack.org/pipermail/openstack-dev/2013-June/010279.html
http://lists.openstack.org/pipermail/openstack-dev/2013-July/011337.html
https://bugs.launchpad.net/nova-project/+bug/1191159

Jay Pipes suggested using the memcache token driver to avoid this problem:

http://lists.openstack.org/pipermail/openstack-dev/2013-June/010289.html

We really should document how to do at least this kind of token backend change to help folks work around this issue.

Revision history for this message
Dolph Mathews (dolph) wrote :

@Lorin: as of havana milestone 1, the following command is available to help alleviate the issue you described:

  $ keystone-manage token_flush

Revision history for this message
Lorin Hochstein (lorinh) wrote :

@dolph: I think it would help if we could provide operators with some guidance on how often they should call token_flush. (e.g., how often it should run in a cron job). Assuming there's no auditing requirement to keep the tokens around, what's a reasonable interval for flushing the tokens? (e.g., once a week? once a day? every hour? every five minutes?)

Revision history for this message
Dolph Mathews (dolph) wrote :

@Lorin: there's been some discussion around that on the openstack-dev list:

  http://lists.openstack.org/pipermail/openstack-dev/2013-July/011167.html

Tom Fifield (fifieldt)
Changed in openstack-manuals:
milestone: none → havana
Revision history for this message
Dolph Mathews (dolph) wrote :

An update on this topic -- we're considering KVS as a deprecated backend, and are now defaulting to SQL. So, I'd prefer if the KVS driver wasn't documented at all. We're also on our way to being able to use memcache (or any other caching layer) on top of the actual token backend [1], so it may make sense to deprecate the memcache token driver in the near future as well. In that case, we'll only have the SQL token driver.

[1]: https://blueprints.launchpad.net/keystone/+spec/caching-layer-for-driver-calls

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/44181

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/44181
Committed: http://github.com/openstack/keystone/commit/ceb017071d3941de5aa9931c5a81aaf17a4797e4
Submitter: Jenkins
Branch: master

commit ceb017071d3941de5aa9931c5a81aaf17a4797e4
Author: David Stanek <email address hidden>
Date: Wed Aug 28 19:45:07 2013 -0400

    Removes KVS references from the documentation

    KVS backends are deprecated and removing references to them from the
    documentation will discourage their use.

    Change-Id: Iad2f9c39f9d92465ada5ecb6001cfc2b225cc01f
    Related-Bug: #986980

Revision history for this message
Nermina Miller (nerminamiller) wrote :

Can this bug be closed? It seems like it was at least partially fixed. I see that SQL driver has been documented in Configuration Reference.

Revision history for this message
Dolph Mathews (dolph) wrote :

AFAIK, the memcache token driver is not documented anywhere (not even keystone.sample.conf), so I think this bug is still valid for both keystone and openstack-manuals.

Using memcache/redis as a caching layer on top of the token driver is now supported and documented fairly well on the keystone side, but we haven't gone so far as deprecate the memcache token driver yet.

Tom Fifield (fifieldt)
Changed in openstack-manuals:
status: Confirmed → Triaged
tags: added: keystone
Revision history for this message
Tom Fifield (fifieldt) wrote :

Also need to add docs about dogpile.

Changed in openstack-manuals:
milestone: havana → icehouse
Tom Fifield (fifieldt)
Changed in openstack-manuals:
importance: Medium → High
Tom Fifield (fifieldt)
Changed in openstack-manuals:
milestone: icehouse → juno
Revision history for this message
Felipe Alfaro Solana (felipe-alfaro-gmail) wrote :

Is there any place where the decision to deprecate the memcache token backend can be discussed? In my opinion, the semantics of memcache are better than those of MySQL for short-lived tokens.

Revision history for this message
Tom Fifield (fifieldt) wrote :

Certainly Felipe - please ask in #openstack-keystone in freenode IRC, or post on the development mailing list: https://wiki.openstack.org/wiki/MailingLists

Revision history for this message
Dolph Mathews (dolph) wrote :

@Felipe: you'll find relevant conversations around the following blueprints:

Superseding the memcache token backend with dogpile as a generic interface to KVS backends: https://blueprints.launchpad.net/keystone/+spec/dogpile-kvs-backends

Dropping the requirement for PKI token persistence entirely: https://blueprints.launchpad.net/keystone/+spec/non-persistent-tokens

Tom Fifield (fifieldt)
Changed in openstack-manuals:
milestone: juno → kilo
tags: added: icehouse-backport-potential
Revision history for this message
Bernd Bausch (berndbausch) wrote :

Is this bug still alive? Both token persistence backends and the caching layer are documented at http://docs.openstack.org/developer/keystone/configuration.html. Should the text be copied to the config reference, or a link place there?

Lucas H. Xu (xuh-2)
Changed in openstack-manuals:
status: Triaged → Confirmed
Dolph Mathews (dolph)
tags: added: documentation
removed: docs keystone
tags: removed: icehouse-backport-potential
Tom Fifield (fifieldt)
Changed in openstack-manuals:
milestone: kilo → liberty
Lana (loquacity)
Changed in openstack-manuals:
status: Confirmed → Fix Released
Ning Sun (ning-sun)
Changed in openstack-manuals:
assignee: nobody → Ning Sun (ning-sun)
Changed in keystone:
assignee: nobody → Ning Sun (ning-sun)
Changed in openstack-manuals:
assignee: Ning Sun (ning-sun) → nobody
Changed in keystone:
assignee: Ning Sun (ning-sun) → nobody
Revision history for this message
Lauren (laucon) wrote :

Hey there. I'm looking for a bug to fix as a part of the outreachy internship application process. Does this issue still exist? Does the token end documentation need cleaning up?

Revision history for this message
Lance Bragstad (lbragstad) wrote :

I have a couple patches proposed to openstack manuals that attempt to document tokens [0] [1]. This documentation pertains to the token *providers* (e.g. uuid, fernet, pki, and pkiz) rather than the backends (e.g. mysql, kvs). I can leverage those patches to try and close this, too. Thoughts?

[0] https://review.openstack.org/#/c/244871/
[1] https://review.openstack.org/#/c/244693/

Revision history for this message
Steve Martinelli (stevemar) wrote :

hey lauren, the developer docs could use some cleaning up: http://docs.openstack.org/developer/keystone/configuration.html#token-provider

Changed in keystone:
importance: Medium → Low
Revision history for this message
Steve Martinelli (stevemar) wrote :

I'm going to say that Dolph's token matrix closed out this bug: https://review.openstack.org/#/c/316118/

Changed in keystone:
status: Confirmed → Fix Released
assignee: nobody → Dolph Mathews (dolph)
milestone: none → newton-3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.