libvirt: make live_migration_uri flag dependent on virt_type

Bug #1547055 reported by OpenStack Infra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Invalid
Undecided
Unassigned
openstack-manuals
Fix Released
Undecided
Unassigned

Bug Description

https://review.openstack.org/175780
Dear bug triager. This bug was created since a commit was marked with DOCIMPACT.
Your project "openstack/nova" is set up so that we directly report the documentation bugs against it. If this needs changing, the docimpact-group option needs to be added for the project. You can ask the OpenStack infra team (#openstack-infra on freenode) for help if you need to.

commit 3159c8fd5bea80c820e58bd38d96f5f8fe8f4503
Author: Alvaro Lopez Garcia <email address hidden>
Date: Tue Apr 21 10:39:30 2015 +0200

    libvirt: make live_migration_uri flag dependent on virt_type

    The default value for the "live_migration_uri" flag should be
    dependent on the "virt_type" flag, as the "connection_uri" flag is. This
    way, an operator can set the "virt_type" flag without the need to check
    for each individual uri.

    DocImpact: Changed the default value of the "live_migration_uri" flag,
    that now is dependent on the "virt_type".
    Closes-Bug: #1298242
    Change-Id: Id54f7bdfa14a19da41da554b13ba9496ee525c71

Revision history for this message
Sean Dague (sdague) wrote :

The manual update required here should be that the live_migration_uri config option has defaults that are automatically selected based on libvirt driver backend (instead of one that only works for qemu/kvm). Less people should need to override this value now.

Changed in nova:
status: New → Invalid
Revision history for this message
Anne Gentle (annegentle) wrote :

Because this is a configuration option, I hope that the automation for configuration options docs would simply pick it up. That said, do we need to write something in addition to what will be scraped?

Revision history for this message
Atsushi SAKAI (sakaia) wrote :

@Anne
I think update the help message as follows for Config reference.
If other discription of live_migration_url exists, it should be removed since a few people should use this parameter.
https://github.com/openstack/nova/blob/5ae39f70f5b202bffd3165ecb9082d4a4f25090b/nova/virt/libvirt/driver.py#L165

https://github.com/openstack/nova/blob/5ae39f70f5b202bffd3165ecb9082d4a4f25090b/nova/virt/libvirt/driver.py#L849

tags: added: autogenerate-config-docs
Changed in openstack-manuals:
status: New → Confirmed
Changed in openstack-manuals:
status: Confirmed → Incomplete
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.