common-rst.pot contains obsolete contents

Bug #1507138 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-manuals
Fix Released
Medium
Akihiro Motoki

Bug Description

doc/common-rst/source/locale/common-rst.pot contains obsolete contents.

common-rst.pot is updated by tools/generatepot-rst.sh, but it only makes additive changes.
We need to throw away deleted or moved contents.

From the mails with Kato-san and Andreas,
we have the following reason of the additive changes.

Quote from Kato-san's mail.
---
Each document uses the common contents. However, each document has the different exclude_patterns, because Sphinx warns if there are unused files. Therefore, each document has a partial common-rst file, not a whole common-rst.
---

From the discussion and my investigation, it seems we need to prepare a document which covers all files under common-rst/.

Akihiro Motoki (amotoki)
Changed in openstack-manuals:
assignee: nobody → Akihiro Motoki (amotoki)
Changed in openstack-manuals:
status: New → Confirmed
importance: Undecided → Medium
Changed in openstack-manuals:
status: Confirmed → In Progress
Revision history for this message
Akihiro Motoki (amotoki) wrote :
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Woops... I added a wrong link.
https://review.openstack.org/#/c/235611/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-manuals (master)

Reviewed: https://review.openstack.org/235611
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=61b9f5a221b95c7a8c66c687d17a621b2dbc44dd
Submitter: Jenkins
Branch: master

commit 61b9f5a221b95c7a8c66c687d17a621b2dbc44dd
Author: Akihiro Motoki <email address hidden>
Date: Sat Oct 17 21:22:26 2015 +0900

    generatepot-rst: dedicate logic to generate common-rst.pot

    Previously common-rst.pot is additive only and
    deleted strings in the source document will remain forever.
    This commit make generatepot-rst.sh not reuse existing
    common-rst.pot and generate the POT file from scratch.

    This patch creates an index rst file which includes all
    files under common-rst and generate common-rst.pot.
    By doing so, all contents of common-rst can be covered.

    Closes-Bug: #1507138
    Change-Id: I888f37ad5e14a0e1cc7d182e376acaf63f98e565

Changed in openstack-manuals:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-manuals 15.0.0

This issue was fixed in the openstack/openstack-manuals 15.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.