hw:watchdog_action should be hw_watchdog_action

Bug #1480408 reported by Tim Bell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-manuals
Fix Released
Low
willy lin

Bug Description

The property hw:watchdog_action is incorrectly documented as an image property. It is a valid flavor property but not an image one since these are hw_ rather than hw:. It should be hw_watchdog_action as for the other parameters.

This is confirmed by ./nova/virt/libvirt/driver.py which contains

        if (image_meta is not None and
                image_meta.get('properties', {}).get('hw_watchdog_action')):
            watchdog_action = image_meta['properties']['hw_watchdog_action']

Checking with
-----------------------------------
Built: 2015-07-31T16:27:56 00:00
git SHA: ff18a434c74fdc90c7a49360982b4bed0755dbfc
URL: http://docs.openstack.org/cli-reference/content/chapter_cli-glance-property.html
source File: file:/home/jenkins/workspace/openstack-manuals-tox-doc-publishdocs/doc/cli-reference/ch_cli_glance_property_keys.xml
xml:id: chapter_cli-glance-property

willy lin (willy-l)
Changed in openstack-manuals:
assignee: nobody → willy lin (willy-l)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-manuals (master)

Fix proposed to branch: master
Review: https://review.openstack.org/208262

Changed in openstack-manuals:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on openstack-manuals (master)

Change abandoned by willy lin (<email address hidden>) on branch: master
Review: https://review.openstack.org/208262

Changed in openstack-manuals:
importance: Undecided → Low
tags: added: config-reference low-hanging-fruit
Tom Fifield (fifieldt)
Changed in openstack-manuals:
milestone: none → liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-manuals (master)

Reviewed: https://review.openstack.org/208771
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=0caf2393c5db3a310d44f30af7d02862ab942399
Submitter: Jenkins
Branch: master

commit 0caf2393c5db3a310d44f30af7d02862ab942399
Author: willy lin <email address hidden>
Date: Tue Aug 4 10:08:11 2015 +0800

    hw:watchdog_action should be hw_watchdog_action

    message:
    change "hw:watchdog_action" to "hw_watchdog_action"

    Change-Id: Ie1245ae0a631c1d58c7b901b3bc3d4564434b016
    Closes-Bug: #1480408

Changed in openstack-manuals:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-manuals 15.0.0

This issue was fixed in the openstack/openstack-manuals 15.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.