Remove force check from copy_volume_to_image

Bug #1447455 reported by OpenStack Infra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-manuals
Fix Released
Low
Unassigned

Bug Description

https://review.openstack.org/176174
commit fb2c434c2461a25193067104de766fc1142a6024
Author: John Griffith <email address hidden>
Date: Wed Apr 22 04:28:34 2015 +0000

    Remove force check from copy_volume_to_image

    The upload_volume_to_image method allows a force parameter that will
    upload a volume even though the volume is attached/in-use. A user can
    get away with this with the LVM driver because the LVM backing is
    local to the Cinder worker node that's pushing the bits to Glance.

    The problem is, this only works for local storage, it won't work
    with any iSCSI devices because they can't do multi-attach. Also,
    the reason we required that a volume NOT be in-use for this
    operation is because we have no way of keeping the guest Instance
    from writing to the volume while we're uploading, and corrupting the data.

    This has been exposed like this for several releases, so removing it
    now likely would not be a good user experience. Instead, this
    patch add a config option to enable/disable it (default is to
    disable), and deployers can choose whether they would like to
    allow the use of --force True or not.

    DocImpact Disables the --force option to copy-volume-to-image and
              introduces "allow_force_upload" boolean option to re-enable

    Change-Id: I1210186689dea204601356f8d08805c6cb6f017c
    Closes-Bug: 1446954

Tags: cinder
Changed in openstack-manuals:
status: New → Triaged
importance: Undecided → Low
Changed in openstack-manuals:
assignee: nobody → jelly (coding1314)
Revision history for this message
Gauvain Pocentek (gpocentek) wrote :

The option name is 'enable_force_upload'.

Changed in openstack-manuals:
assignee: jelly (coding1314) → Gauvain Pocentek (gpocentek)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-manuals (master)

Reviewed: https://review.openstack.org/203409
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=523d46a8b6bdc6bae51b01443c46d4ec1fa7bce6
Submitter: Jenkins
Branch: master

commit 523d46a8b6bdc6bae51b01443c46d4ec1fa7bce6
Author: Gauvain Pocentek <email address hidden>
Date: Sun Jul 19 10:53:46 2015 +0200

    [config-ref] Cinder option tables update

    Remove the quobyte documentation since it is not in the cinder tree
    anymore.

    Closes-Bug: #1474495
    Closes-Bug: #1469518
    Closes-Bug: #1467587
    Closes-Bug: #1467170
    Partial-Bug: #1467123
    Partial-Bug: #1466971
    Closes-Bug: #1466163
    Partial-Bug: #1465700
    Partial-Bug: #1464726
    Closes-Bug: #1462459
    Closes-Bug: #1462184
    Closes-Bug: #1460811
    Closes-Bug: #1460366
    Closes-Bug: #1458714
    Closes-Bug: #1453247
    Closes-Bug: #1451526
    Partial-Bug: #1447455
    Partial-Bug: #1445154
    Closes-Bug: #1444814
    Closes-Bug: #1385248

    Change-Id: I6eec26af059d7d390b2b3875b346fcb50c8100a5

Changed in openstack-manuals:
assignee: Gauvain Pocentek (gpocentek) → nobody
Revision history for this message
Alexandra Settle (alexandra-settle) wrote :

This has been updated in the config guide by the auto tool.

Changed in openstack-manuals:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.